Re: [VOTE] KIP-229: DeleteGroups API

2018-01-23 Thread Vahid S Hashemian
afka.apache.org Date: 01/22/2018 11:06 AM Subject: Re: [VOTE] KIP-229: DeleteGroups API Bumping this thread as this KIP requires only one more binding +1 to make it to 1.1.0. Thanks. --Vahid From: "Vahid S Hashemian" To: dev@kafka.apache.org Date: 01/16/2018 10:41 AM

Re: [VOTE] KIP-229: DeleteGroups API

2018-01-22 Thread Jason Gustafson
> To: dev@kafka.apache.org > Date: 01/16/2018 10:41 AM > Subject:Re: [VOTE] KIP-229: DeleteGroups API > > > > Thanks Colin. > > Your suggestion is fair. I added a GROUP_ID_NOT_FOUND error to cover the > group deletion case where the group id does not exist

Re: [VOTE] KIP-229: DeleteGroups API

2018-01-22 Thread Vahid S Hashemian
Bumping this thread as this KIP requires only one more binding +1 to make it to 1.1.0. Thanks. --Vahid From: "Vahid S Hashemian" To: dev@kafka.apache.org Date: 01/16/2018 10:41 AM Subject: Re: [VOTE] KIP-229: DeleteGroups API Thanks Colin. Your suggestion is fai

Re: [VOTE] KIP-229: DeleteGroups API

2018-01-16 Thread Vahid S Hashemian
@kafka.apache.org Date: 01/16/2018 10:06 AM Subject:Re: [VOTE] KIP-229: DeleteGroups API Thanks for this KIP, Vahid. +1 (non-binding). How about creating a GROUP_ID_NOT_FOUND error, rather than re-using INVALID_GROUP_ID here? INVALID_GROUP_ID is used to indicate that the group id itself

Re: [VOTE] KIP-229: DeleteGroups API

2018-01-16 Thread Vahid S Hashemian
paragraph there too. Thanks. --Vahid From: Guozhang Wang To: dev@kafka.apache.org Date: 01/16/2018 09:32 AM Subject: Re: [VOTE] KIP-229: DeleteGroups API Thanks Vahid, +1 (binding) from me. A minor question as for tooling improvements you mentioned in the wiki, are we goin

Re: [VOTE] KIP-229: DeleteGroups API

2018-01-16 Thread Colin McCabe
t; >> -- > > >> > > >> Edoardo Comar > > >> > > >> IBM Message Hub > > >> > > >> IBM UK Ltd, Hursley Park, SO21 2JN > > >> > > >> > > >>

Re: [VOTE] KIP-229: DeleteGroups API

2018-01-16 Thread Guozhang Wang
> >> IBM Message Hub > >> > >> IBM UK Ltd, Hursley Park, SO21 2JN > >> > >> > >> > >> From: Ted Yu > >> To: dev@kafka.apache.org > >> Date: 15/01/2018 20:33 > >> Subject:Re: [VOTE] KIP-229:

Re: [VOTE] KIP-229: DeleteGroups API

2018-01-16 Thread Mickael Maison
; >> +1 (non binding) - thanks Vahid >> >> -- >> >> Edoardo Comar >> >> IBM Message Hub >> >> IBM UK Ltd, Hursley Park, SO21 2JN >> >> >> >> From: Ted Yu >> To: dev@kafka.apache.org >>

Re: [VOTE] KIP-229: DeleteGroups API

2018-01-16 Thread Rajini Sivaram
Ltd, Hursley Park, SO21 2JN > > > > From: Ted Yu > To: dev@kafka.apache.org > Date: 15/01/2018 20:33 > Subject:Re: [VOTE] KIP-229: DeleteGroups API > > > > +1 > > On Mon, Jan 15, 2018 at 12:22 PM, Jeff Widman wrote: > > > +1 (non-

Re: [VOTE] KIP-229: DeleteGroups API

2018-01-16 Thread Edoardo Comar
+1 (non binding) - thanks Vahid -- Edoardo Comar IBM Message Hub IBM UK Ltd, Hursley Park, SO21 2JN From: Ted Yu To: dev@kafka.apache.org Date: 15/01/2018 20:33 Subject:Re: [VOTE] KIP-229: DeleteGroups API +1 On Mon, Jan

Re: [VOTE] KIP-229: DeleteGroups API

2018-01-15 Thread Ted Yu
+1 On Mon, Jan 15, 2018 at 12:22 PM, Jeff Widman wrote: > +1 (non-binding) > > On Jan 15, 2018 10:23 AM, "Vahid S Hashemian" > wrote: > > > Happy Monday, > > > > I believe the concerns on this KIP have been addressed in the current > > version of the KIP: > > https://cwiki.apache.org/confluence

Re: [VOTE] KIP-229: DeleteGroups API

2018-01-15 Thread Jeff Widman
+1 (non-binding) On Jan 15, 2018 10:23 AM, "Vahid S Hashemian" wrote: > Happy Monday, > > I believe the concerns on this KIP have been addressed in the current > version of the KIP: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 229%3A+DeleteGroups+API > So I'd like to start a vote.