+1 (binding) On Mon, Jan 22, 2018 at 11:06 AM, Vahid S Hashemian < vahidhashem...@us.ibm.com> wrote:
> Bumping this thread as this KIP requires only one more binding +1 to make > it to 1.1.0. > > Thanks. > --Vahid > > > > From: "Vahid S Hashemian" <vahidhashem...@us.ibm.com> > To: dev@kafka.apache.org > Date: 01/16/2018 10:41 AM > Subject: Re: [VOTE] KIP-229: DeleteGroups API > > > > Thanks Colin. > > Your suggestion is fair. I added a GROUP_ID_NOT_FOUND error to cover the > group deletion case where the group id does not exist. > I hope this change is what you had in mind, and also hope it does not void > > the votes cast so far :) > > --Vahid > > > > > From: Colin McCabe <cmcc...@apache.org> > To: dev@kafka.apache.org > Date: 01/16/2018 10:06 AM > Subject: Re: [VOTE] KIP-229: DeleteGroups API > > > > Thanks for this KIP, Vahid. +1 (non-binding). > > How about creating a GROUP_ID_NOT_FOUND error, rather than re-using > INVALID_GROUP_ID here? INVALID_GROUP_ID is used to indicate that the > group id itself is bad (contains invalid characters, is an empty string, > etc.). A group ID not being found on the server is different than the ID > itself not being valid. We should probably not combine these two error > cases. > > On Tue, Jan 16, 2018, at 09:31, Guozhang Wang wrote: > > Thanks Vahid, +1 (binding) from me. > > > > A minor question as for tooling improvements you mentioned in the wiki, > are > > we going to add a `--delete` option on the `kafka-consumer-groups.sh` > > script? I thought it is "yes" but the Proposed Changes section does not > > explicitly mention it. > > +1 for a --delete option on kafka-consumer-groups.sh > > regards, > Colin > > > > > > > Guozhang > > > > > > On Tue, Jan 16, 2018 at 5:55 AM, Mickael Maison > <mickael.mai...@gmail.com> > > wrote: > > > > > +1 (non binding) > > > Thanks for the KIP > > > > > > On Tue, Jan 16, 2018 at 11:54 AM, Rajini Sivaram > > > <rajinisiva...@gmail.com> wrote: > > > > Hi Vahid, > > > > > > > > +1 (binding) > > > > > > > > Thanks for the KIP. > > > > > > > > Regards, > > > > > > > > Rajini > > > > > > > > On Tue, Jan 16, 2018 at 10:24 AM, Edoardo Comar <eco...@uk.ibm.com> > > > wrote: > > > > > > > >> +1 (non binding) - thanks Vahid > > > >> > > > >> -------------------------------------------------- > > > >> > > > >> Edoardo Comar > > > >> > > > >> IBM Message Hub > > > >> > > > >> IBM UK Ltd, Hursley Park, SO21 2JN > > > >> > > > >> > > > >> > > > >> From: Ted Yu <yuzhih...@gmail.com> > > > >> To: dev@kafka.apache.org > > > >> Date: 15/01/2018 20:33 > > > >> Subject: Re: [VOTE] KIP-229: DeleteGroups API > > > >> > > > >> > > > >> > > > >> +1 > > > >> > > > >> On Mon, Jan 15, 2018 at 12:22 PM, Jeff Widman <j...@jeffwidman.com> > > > wrote: > > > >> > > > >> > +1 (non-binding) > > > >> > > > > >> > On Jan 15, 2018 10:23 AM, "Vahid S Hashemian" > > > >> <vahidhashem...@us.ibm.com> > > > >> > wrote: > > > >> > > > > >> > > Happy Monday, > > > >> > > > > > >> > > I believe the concerns on this KIP have been addressed in the > > > current > > > >> > > version of the KIP: > > > >> > > > > > >> https://urldefense.proofpoint.com/v2/url?u=https-3A__cwiki. > > > >> apache.org_confluence_display_KAFKA_KIP-2D&d=DwIBaQ&c=jf_ > > > >> > iaSHvJObTbx-siA1ZOg&r=EzRhmSah4IHsUZVekRUIINhltZK7U0OaeRo7hgW4_tQ&m= > > > >> gy9vDnDO2DIaWpZBxdO89w7Pxx5mZNKksKLbjB4_Yp4&s=XYsVEz3hq1Qyb8Oho_ > > > >> z7iSlv88IVioUD4iIQ9gp_Trc&e= > > > >> > > > >> > > 229%3A+DeleteGroups+API > > > >> > > So I'd like to start a vote. > > > >> > > > > > >> > > Thanks. > > > >> > > --Vahid > > > >> > > > > > >> > > > > > >> > > > > >> > > > >> > > > >> > > > >> Unless stated otherwise above: > > > >> IBM United Kingdom Limited - Registered in England and Wales with > number > > > >> 741598. > > > >> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire > PO6 > > > 3AU > > > >> > > > > > > > > > > > -- > > -- Guozhang > > > > > > > > > >
