Re: [REVIEW REQUEST] Move ReassignPartitionsCommandArgsTest to java

2023-08-28 Thread Николай Ижиков
Hello, Mickael. Thanks for the reply and reviewing previous patches for this feature :). Just to let all know - I’ve got one approval from non commiter. So, if any committer has spare cycle, please, join the simple review that will help to rewrite tools in java https://github.com/apache/kafka/p

Re: [REVIEW REQUEST] Move ReassignPartitionsCommandArgsTest to java

2023-08-25 Thread Mickael Maison
Hi Nikolay, Thanks for working on this feature. Take into account that many people are on PTO at the moment and there's a lot of PRs to review. Not sure why fixVersion was set to 3.6.0. Apart for key features or fixes, it's usually best to only set the fixVersion once the code has been merged. I'v

Re: [REVIEW REQUEST] Move ReassignPartitionsCommandArgsTest to java

2023-08-25 Thread Николай Ижиков
Hello, Luke Thanks for reply. Actually, KAFKA-14595 [1] has fixVersion = 3.6.0 And the PR is part of the ticket. Several review required If we want to include java version of ReassignPartitionCommand in 3.6.0 [1] https://issues.apache.org/jira/browse/KAFKA-14595 > 23 авг. 2023 г., в 10:07, L

Re: [REVIEW REQUEST] Move ReassignPartitionsCommandArgsTest to java

2023-08-23 Thread Luke Chen
Hi, Sorry that we're mostly working on features for v3.6.0, which is expected to be released in the following weeks. I'll review your PR after releasing. (Please ping me then if I forget it!) Also, it'd be good if the devs in the community can help on PR review when available. That'll help a lot.

Re: [REVIEW REQUEST] Move ReassignPartitionsCommandArgsTest to java

2023-08-22 Thread Николай Ижиков
Hello. Please, join the simple review) We have few steps left to completely rewrite ReassignPartitionsCommand in java. > 17 авг. 2023 г., в 17:16, Николай Ижиков написал(а): > > Hello. > > I’m working on [1]. > The goal of ticket is to rewire `ReassignPartitionCommand` in java. > > The PR tha