Hi, Sorry that we're mostly working on features for v3.6.0, which is expected to be released in the following weeks. I'll review your PR after releasing. (Please ping me then if I forget it!)
Also, it'd be good if the devs in the community can help on PR review when available. That'll help a lot. Besides, PR review is also one kind of contribution, not just code commitment. Thanks. Luke On Tue, Aug 22, 2023 at 7:15 PM Николай Ижиков <nizhi...@apache.org> wrote: > Hello. > > Please, join the simple review) > We have few steps left to completely rewrite ReassignPartitionsCommand in > java. > > > 17 авг. 2023 г., в 17:16, Николай Ижиков <nizhikov....@gmail.com> > написал(а): > > > > Hello. > > > > I’m working on [1]. > > The goal of ticket is to rewire `ReassignPartitionCommand` in java. > > > > The PR that moves whole command is pretty big so it makes sense to split > it. > > I prepared the PR [2] that moves single test > (ReassignPartitionsCommandArgsTest) to java. > > > > It relatively small and simple(touches only 3 files): > > > > To review - https://github.com/apache/kafka/pull/14217 > > Big PR - https://github.com/apache/kafka/pull/13247 > > > > Please, review. > > > > [1] https://issues.apache.org/jira/browse/KAFKA-14595 > > [2] https://github.com/apache/kafka/pull/14217 > >
