Re: [DISCUSS] KIP-396: Add Commit/List Offsets Operations to AdminClient

2019-01-02 Thread Mickael Maison
It's now been a few weeks without any feedback. If I don't see anything new, I'll start a vote early next week. Thanks On Tue, Dec 11, 2018 at 6:00 PM Mickael Maison wrote: > > Thanks for the feedback Edo. > > 1) While the initial name was matching the Protocol, I agree it was > not great for u

Re: [DISCUSS] KIP-396: Add Commit/List Offsets Operations to AdminClient

2018-12-11 Thread Mickael Maison
Thanks for the feedback Edo. 1) While the initial name was matching the Protocol, I agree it was not great for users. I've updated commitOffsets() to commitConsumerGroupOffsets() as suggested. 2) I thought passing the timestamp for each partition would make it harder to use in the most common cas

Re: [DISCUSS] KIP-396: Add Commit/List Offsets Operations to AdminClient

2018-11-30 Thread Edoardo Comar
Thanks for the KIP Mickael! two initial observations `commitOffsets` methods could be renamed to `commitConsumerGroupOffsets` to better match the existing `listConsumerGroupOffsets` `ListOffsetsOptions` offers you a per-request isolation level option and timestamp, but timestamp is a per-parti