Totally agree about getting things right in the first round. In addition, I
believe that it is important that names of our tools will describe what the
tools do as accurately as possible - this improves usability. Therefore, we
should shift the discussion to whether the tool should handle all offse
I don't think it's bikeshedding and it is a fair question. I try to avoid
that because this is part of the point of KIPs -- avoid extra pain around
usability, documentation, maintenance, and compatibility and deprecation by
just trying to get things right on the first go around.
It's obviously jus
>
>
> > * re: naming, can we avoid including 'source' in the command name? even
> if
> > that's all it supports today, I don't think we want to restrict it. While
> > we only *require* this for source offsets, I think for users it will,
> > long-term, be way more natural to consider connect offsets
Thanks for the comments. As mentioned in the VOTE thread, I've withdrawn
the vote since this proposal is obviously incomplete. I have updated the
KIP with your comments, and will discuss each inline below:
On Mon, Sep 11, 2017 at 11:30 PM, Ewen Cheslack-Postava
wrote:
> A couple of comments:
>
>
A couple of comments:
* I made some minor, non-critical updates to the motivation section to add
a bit more color/background/clarity. In particular, clarifying how things
are connected to consumer groups for sinks. Still, the motivation isn't
entirely clear about how this works -- it is definitely
bq. How about calling it kafka-connect-source-offset-tool.sh
This is better.
Going over existing .sh files, some have verb in their names while some
don't.
+1 from me.
On Sun, Sep 10, 2017 at 2:53 PM, Randall Hauch wrote:
> Thanks for the comments! Specific comments inline below.
>
> Regards,
Thanks for the comments! Specific comments inline below.
Regards,
Randall
On Sun, Sep 10, 2017 at 2:42 PM, Ted Yu wrote:
> bq. connector restart and the next message
>
> The last part of the sentence seems to be incomplete.
>
Fixed.
> bq. command line tool called kafka-connect-source-offset
bq. connector restart and the next message
The last part of the sentence seems to be incomplete.
bq. command line tool called kafka-connect-source-offset-reset.sh
>From the description, the tool does more than resetting (e.g. deleting).
How about calling it kafka-connect-source-offset-tool.sh
b
