Thanks for the comments! Specific comments inline below. Regards,
Randall On Sun, Sep 10, 2017 at 2:42 PM, Ted Yu <yuzhih...@gmail.com> wrote: > bq. connector restart and the next message > > The last part of the sentence seems to be incomplete. > Fixed. > bq. command line tool called kafka-connect-source-offset-reset.sh > > From the description, the tool does more than resetting (e.g. deleting). > How about calling it kafka-connect-source-offset-tool.sh > None of the other tools or scripts in the Kafka distribution have "tool" in the name, so how about "kafka-connect-source-offsets.sh"? > > bq. bin/kafka-connect-source-offset-reset.sh > --config=my-worker-config.properties --export > > From the table above, export mode is mentioned as required. However, either > --export or --import is required. > Better note this in the KIP. > Addressed in a few places. Hopefully it is more clear now. > > bq. but will remove the offsets for the partition with file "b" > > Please move the sample JSON below the above description. > Done. > > Cheers > > On Sun, Sep 10, 2017 at 11:12 AM, Randall Hauch <rha...@gmail.com> wrote: > > > Hi all, > > > > KIP-199 [1] describes a new tool that will allow Connect operators to > read, > > update, and remove offsets stored by Connect runtime. This capability has > > been often asked for by Connect users. The proposal is simple but > flexible. > > Please review and add feedback. > > > > Best regards, > > > > Randall > > > > [1] > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 199%3A+Add+Kafka+Connect+offset+reset+tool > > >
