Re: [DISCUSS] KIP-153 : Include only client traffic in BytesOutPerSec metric

2017-05-07 Thread Jun Rao
Hi, Xavier, I think the per topic metric is more useful for measuring the traffic from the clients. For internal replication, perhaps the aggregate value is enough. Thanks, Jun On Fri, May 5, 2017 at 6:11 PM, Xavier Léauté wrote: > Any reason we are not keeping the per-topic breakdown for int

Re: [DISCUSS] KIP-153 : Include only client traffic in BytesOutPerSec metric

2017-05-06 Thread Edoardo Comar
Thanks for the KIP, Jun We're constantly reminded of this inconsistency when we look at the traffic on the dashboards ! -- Edoardo Comar IBM MessageHub eco...@uk.ibm.com IBM UK Ltd, Hursley Park, SO21 2JN IBM United Kingdom Limited Registered in Eng

Re: [DISCUSS] KIP-153 : Include only client traffic in BytesOutPerSec metric

2017-05-05 Thread Xavier Léauté
Any reason we are not keeping the per-topic breakdown for inter-broker traffic? On Fri, May 5, 2017 at 4:52 PM Onur Karaman wrote: > Looks good. Thanks! > > On Fri, May 5, 2017 at 4:44 PM, Roger Hoover > wrote: > > > Very helpful. Thank you, Jun. > > > > On Fri, May 5, 2017 at 4:42 PM, Guozha

Re: [DISCUSS] KIP-153 : Include only client traffic in BytesOutPerSec metric

2017-05-05 Thread Onur Karaman
Looks good. Thanks! On Fri, May 5, 2017 at 4:44 PM, Roger Hoover wrote: > Very helpful. Thank you, Jun. > > On Fri, May 5, 2017 at 4:42 PM, Guozhang Wang wrote: > > > Jun, > > > > Thanks for the KIP, LGTM. > > > > Guozhang > > > > On Fri, May 5, 2017 at 3:38 PM, Ismael Juma wrote: > > > > > T

Re: [DISCUSS] KIP-153 : Include only client traffic in BytesOutPerSec metric

2017-05-05 Thread Roger Hoover
Very helpful. Thank you, Jun. On Fri, May 5, 2017 at 4:42 PM, Guozhang Wang wrote: > Jun, > > Thanks for the KIP, LGTM. > > Guozhang > > On Fri, May 5, 2017 at 3:38 PM, Ismael Juma wrote: > > > Thanks Jun, looks good to me. > > > > Ismael > > > > On Fri, May 5, 2017 at 11:35 PM, Jun Rao wrote

Re: [DISCUSS] KIP-153 : Include only client traffic in BytesOutPerSec metric

2017-05-05 Thread Guozhang Wang
Jun, Thanks for the KIP, LGTM. Guozhang On Fri, May 5, 2017 at 3:38 PM, Ismael Juma wrote: > Thanks Jun, looks good to me. > > Ismael > > On Fri, May 5, 2017 at 11:35 PM, Jun Rao wrote: > > > Hi, Ismael, > > > > Good point. Updated the KIP with ReplicationBytesInPerSec. > > > > Thanks, > > >

Re: [DISCUSS] KIP-153 : Include only client traffic in BytesOutPerSec metric

2017-05-05 Thread Ismael Juma
Thanks Jun, looks good to me. Ismael On Fri, May 5, 2017 at 11:35 PM, Jun Rao wrote: > Hi, Ismael, > > Good point. Updated the KIP with ReplicationBytesInPerSec. > > Thanks, > > Jun > > On Fri, May 5, 2017 at 3:16 PM, Ismael Juma wrote: > > > Thanks for the KIP, Jun. Good to fix this inconsist

Re: [DISCUSS] KIP-153 : Include only client traffic in BytesOutPerSec metric

2017-05-05 Thread Jun Rao
Hi, Ismael, Good point. Updated the KIP with ReplicationBytesInPerSec. Thanks, Jun On Fri, May 5, 2017 at 3:16 PM, Ismael Juma wrote: > Thanks for the KIP, Jun. Good to fix this inconsistency. Do I understand > correctly that we are introducing ReplicationBytesOutPerSec, but not > Replication

Re: [DISCUSS] KIP-153 : Include only client traffic in BytesOutPerSec metric

2017-05-05 Thread Ismael Juma
Thanks for the KIP, Jun. Good to fix this inconsistency. Do I understand correctly that we are introducing ReplicationBytesOutPerSec, but not ReplicationBytesInPerSec? If so, what's the reason? Ismael On Fri, May 5, 2017 at 11:11 PM, Jun Rao wrote: > Hi, Everyone, > > We created "KIP-153 : Incl