Looks good. Thanks! On Fri, May 5, 2017 at 4:44 PM, Roger Hoover <roger.hoo...@gmail.com> wrote:
> Very helpful. Thank you, Jun. > > On Fri, May 5, 2017 at 4:42 PM, Guozhang Wang <wangg...@gmail.com> wrote: > > > Jun, > > > > Thanks for the KIP, LGTM. > > > > Guozhang > > > > On Fri, May 5, 2017 at 3:38 PM, Ismael Juma <ism...@juma.me.uk> wrote: > > > > > Thanks Jun, looks good to me. > > > > > > Ismael > > > > > > On Fri, May 5, 2017 at 11:35 PM, Jun Rao <j...@confluent.io> wrote: > > > > > > > Hi, Ismael, > > > > > > > > Good point. Updated the KIP with ReplicationBytesInPerSec. > > > > > > > > Thanks, > > > > > > > > Jun > > > > > > > > On Fri, May 5, 2017 at 3:16 PM, Ismael Juma <ism...@juma.me.uk> > wrote: > > > > > > > > > Thanks for the KIP, Jun. Good to fix this inconsistency. Do I > > > understand > > > > > correctly that we are introducing ReplicationBytesOutPerSec, but > not > > > > > ReplicationBytesInPerSec? > > > > > If so, what's the reason? > > > > > > > > > > Ismael > > > > > > > > > > On Fri, May 5, 2017 at 11:11 PM, Jun Rao <j...@confluent.io> wrote: > > > > > > > > > > > Hi, Everyone, > > > > > > > > > > > > We created "KIP-153 : Include only client traffic in > BytesOutPerSec > > > > > > metric". > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > > > > 153+%3A+Include+only+client+traffic+in+BytesOutPerSec+metric > > > > > > > > > > > > Please take a look and provide your feedback. > > > > > > > > > > > > Thanks, > > > > > > > > > > > > Jun > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > -- Guozhang > > >
