Re: [DISCUSS] KIP-1118: Add Deadlock Protection on Producer Network Thread

2024-12-04 Thread Kirk True
y address Producer#flush. Producer#close already has > defined behaviour. Those are the most important ones. > > Thanks, > Andrew > > From: TengYao Chi > Sent: 04 December 2024 09:02 > To: dev@kafka.apache.org > Subject: Re: [DISCU

Re: [DISCUSS] KIP-1118: Add Deadlock Protection on Producer Network Thread

2024-12-04 Thread Andrew Schofield
ndrew From: TengYao Chi Sent: 04 December 2024 09:02 To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-1118: Add Deadlock Protection on Producer Network Thread Hi Kirk, Thanks for your feedback as well. IMHO, we should primarily focus on potential deadlock or other critical i

Re: [DISCUSS] KIP-1118: Add Deadlock Protection on Producer Network Thread

2024-12-03 Thread Kirk True
Hi TengYao, Thanks for the KIP. I want to ask Andrew's question in an inverted perspective: Which—if any—Producer APIs should users be allowed to invoke from within a Callback? I agree about transactions being off limits. Just... no. But should users be able to call either send() variant from

Re: [DISCUSS] KIP-1118: Add Deadlock Protection on Producer Network Thread

2024-12-03 Thread Andrew Schofield
Hi TengYao, Thanks for the KIP. From my point of view, calling Producer#flush in a callback is a bad idea and it would be better to disallow it. AS1: If we are tightening up the rules about which Producer methods can be called in the callback, I wonder whether some other methods should be treate