Re: [DISCUSS] - KIP-1064: Upgrade slf4j to 2.x

2025-04-29 Thread Chia-Ping Tsai
hi Colin The compatibility issue could arise if the version of the custom SLF4j provider used by users does not match the SLF4j API version bundled with Kafka. For example, if we upgrade the SLF4j API version to 2.x, users who are still using slf4j-simple 1.x might encounter some issues. See the S

Re: [DISCUSS] - KIP-1064: Upgrade slf4j to 2.x

2025-04-28 Thread Colin McCabe
Hi, Can you clarify the discussion about compatibility? I wasn't able to figure out whether the change is compatible or not based on reading through the KIP. If it is not compatible, what specific actions are needed from users? best, Colin On Tue, Mar 25, 2025, at 05:10, TengYao Chi wrote: > H

Re: [DISCUSS] - KIP-1064: Upgrade slf4j to 2.x

2025-03-25 Thread TengYao Chi
Hi Federico, > - I would expand the motivation section rather than linking to the discussion I just reviewed it, and I think we could remove this reference since it doesn't provide much value to this KIP. >- I think we should now update the `log4j2.properties` reference to `log4j2.yaml` Thanks

Re: [DISCUSS] - KIP-1064: Upgrade slf4j to 2.x

2025-03-25 Thread Federico Valeri
Hi TengYao, this change makes sense for a major release. Some comments: - I would expand the motivation section rather than linking to the discussion - I think we should now update the `log4j2.properties` reference to `log4j2.yaml` On Mon, Mar 10, 2025 at 7:36 AM TengYao Chi wrote: > > Hi Ismael

Re: [DISCUSS] - KIP-1064: Upgrade slf4j to 2.x

2025-03-09 Thread TengYao Chi
Hi Ismael Thanks for pointing this out. I have just updated the "Compatibility, Deprecation, and Migration Plan" section and indicated that we should only introduce this change if we are sure the compatibility isn't broken. Please take a look. Best, TengYao Ismael Juma 於 2025年3月10日 週一 下午12:51

Re: [DISCUSS] - KIP-1064: Upgrade slf4j to 2.x

2025-03-09 Thread Ismael Juma
Thanks for updating the KIP. A comment below: As we introduce this change in major version 4.1.0, since we provide the > backend binding dependencies, users should be able to upgrade their backend > dependencies. 4.1 is a minor version (not major version). So, this KIP is only acceptable in 4.1.

Re: [DISCUSS] - KIP-1064: Upgrade slf4j to 2.x

2025-03-09 Thread TengYao Chi
Hello guys, I have taken over this KIP from Muralidhar. Given that the original content is outdated since the logging framework has been widely changed, I have updated the content of the KIP. Please take a look and share your thoughts. Best Regards, TengYao TengYao Chi 於 2025年2月23日 週日 下午3:19寫道:

Re: [DISCUSS] - KIP-1064: Upgrade slf4j to 2.x

2025-02-22 Thread TengYao Chi
Hi Muralidhar, Thanks for the KIP. Since we have migrated to log4j2, the KIP content must also be updated. Best Regards, TengYao Muralidhar Basani 於 2024年9月10日 週二 下午1:21寫道: > Hi, > > I assume there are no concerns. Will start a voting thread. > > Thanks, > Murali > > On Fri, Sep 6, 2024 at 2:

Re: [DISCUSS] - KIP-1064: Upgrade slf4j to 2.x

2024-07-04 Thread Chia-Ping Tsai
> > Or do we also provide other binding jars for logback, log4j, simple etc ? yep, that is a solution which kafka can have strong dependencies on those, but we need to reach the consensus about "which" providers should be included Muralidhar Basani 於 2024年7月5日 週五 上午3:50寫道: > Hi Chia, > Thank y

Re: [DISCUSS] - KIP-1064: Upgrade slf4j to 2.x

2024-07-04 Thread Muralidhar Basani
Hi Chia, Thank you for dropping by on this. I have updated both the discussion thread and the Compatibility section partly. But I would like to discuss a bit more about this and update. 3. how to keep the compatibility of updating slf4j version in the future? According to slf4j compatibility ( ht

Re: [DISCUSS] - KIP-1064: Upgrade slf4j to 2.x

2024-07-04 Thread Chia-Ping Tsai
hi Muralidhar thanks for writing the KIP. Please take a look at following comments: 1. please update the Discussion thread. it has incorrect link 2. please complete the section "Compatibility, Deprecation, and Migration Plan". We had a good discussion in the PR ( https://github.com/apache/kafka