Re: Possible bug in Streams → KStreamImpl.java

2016-03-02 Thread Avi Flax
On Mon, Feb 29, 2016 at 6:34 PM, Guozhang Wang wrote: > Thanks for pointing it out! My pleasure! > And yes it is indeed a bug in the code. Could > you file a HOTFIX PR fixing this and also modify the existing unit test to > cover this case? Sorry, I missed your email until just now. I’m glad to

Re: Possible bug in Streams → KStreamImpl.java

2016-03-01 Thread Guozhang Wang
Filed hotfix PR https://github.com/apache/kafka/pull/991. On Mon, Feb 29, 2016 at 3:34 PM, Guozhang Wang wrote: > Hi Avi, > > Thanks for pointing it out! And yes it is indeed a bug in the code. Could > you file a HOTFIX PR fixing this and also modify the existing unit test to > cover this case?

Re: Possible bug in Streams → KStreamImpl.java

2016-02-29 Thread Guozhang Wang
Hi Avi, Thanks for pointing it out! And yes it is indeed a bug in the code. Could you file a HOTFIX PR fixing this and also modify the existing unit test to cover this case? Thanks, Guozhang On Mon, Feb 29, 2016 at 2:15 PM, Avi Flax wrote: > I was just playing around with Streams’ join feature

Possible bug in Streams → KStreamImpl.java

2016-02-29 Thread Avi Flax
I was just playing around with Streams’ join features, just to get a feel for them, and I think I may have noticed a bug in the code, in KStreamImpl.java on line 310: https://github.com/apache/kafka/blob/845c6eae1f6c6bcf117f5baa53bb19b4611c0528/streams/src/main/java/org/apache/kafka/streams/kstrea