Re: Kafka patch review process

2013-09-13 Thread Neha Narkhede
>> I think we may be saying the same thing. I am differentiating between regular contributors (who are likely committers) and first-time contributors. Agree with this. Once the review tool is stabilized and reviewed, will update the patch workflow wiki to reflect this distinction. Thanks, Neha

Re: Kafka patch review process

2013-09-13 Thread Neha Narkhede
Thanks for the feedback. This tool is actually designed to reduce the review overhead and make reviews less time consuming and more readable. So this is more of a contributor's workflow than a committer's workflow. I agree that this might be too much of a process to follow for one-time smallish co

Re: Kafka patch review process

2013-09-12 Thread Jay Kreps
I think we may be saying the same thing. I am differentiating between regular contributors (who are likely committers) and first-time contributors. What I am saying is that if I had made some small change to a piece of open source software and they asked me to install some new software to give the

Re: Kafka patch review process

2013-09-11 Thread Jay Kreps
I think this is awesome! Two quick things: 1. I think once we have vetted review board and this tool it would be good to consolidate the committer workflow documentation. Currently we have a git workflow, a review board workflow and a review tool workflow. I actually do not have the ability to re

Kafka patch review process

2013-09-11 Thread Neha Narkhede
Hi, I'm proposing a new patch review process that will save time on code reviews and make the patch review process easier, with a one time setup cost. I wrote a tool that will do 2 things - 1. Create a patch and upload it to an existing JIRA 2. Create/update reviewboard with the same patch and l