I think this is awesome! Two quick things:
1. I think once we have vetted review board and this tool it would be good to consolidate the committer workflow documentation. Currently we have a git workflow, a review board workflow and a review tool workflow. I actually do not have the ability to remember any more commands, and have to jump between projects with different tools, so I refer to these kinds of things a lot. 2. I don't think this is very good for people trying to make first-time contributions to Kafka. We already have a fair amount of rigamarole from Apache with creating JIRAs and uploading patches vs the github workflow people prefer. The git workflow outlines a contributor and committer workflow and I think we should retain that distinction and just recommend the extra tooling to committers. -Jay On Wed, Sep 11, 2013 at 5:55 PM, Neha Narkhede <neha.narkh...@gmail.com>wrote: > Hi, > > I'm proposing a new patch review process that will save time on code > reviews and make the patch review process easier, with a one time setup > cost. > > I wrote a tool that will do 2 things - > > 1. Create a patch and upload it to an existing JIRA > 2. Create/update reviewboard with the same patch and link it back to the > JIRA > 3. Update JIRA with a comment that points to the reviewboard > > To use this tool, you will need to go through a one-time setup cost of > installing jira command line tools and reviewboard tools. The setup as well > as usage is documented here > <https://cwiki.apache.org/confluence/display/KAFKA/Kafka+patch+review+tool > > > > I've created a rb <https://reviews.apache.org/r/14091/> as well as created > a JIRA <https://issues.apache.org/jira/browse/KAFKA-1053> for this (yes, > using the tool :)) > > So the proposed patch review process is - > > 1. Create a JIRA > 2. Make code changes and commit to local branch > 3. Use the patch review > tool< > https://cwiki.apache.org/confluence/display/KAFKA/Kafka+patch+review+tool > >that > will update the JIRA with the patch and create/update the > corresponding reviewboard > > Will be great if people can give this a spin and provide feedback on the > new patch review process. > > Thanks, > Neha >
