hem...@us.ibm.com>) escribió:
Thanks Jorge for addressing my suggestions. Looks good to me.
--Vahid
From: Jorge Esteban Quilcate Otoya
To: dev@kafka.apache.org
Date: 02/27/2017 01:57 AM
Subject: Re: KIP-122: Add a tool to Reset Consumer Group Offsets
@Vahid: make sense to add &q
Thanks Jorge for addressing my suggestions. Looks good to me.
--Vahid
From: Jorge Esteban Quilcate Otoya
To: dev@kafka.apache.org
Date: 02/27/2017 01:57 AM
Subject:Re: KIP-122: Add a tool to Reset Consumer Group Offsets
@Vahid: make sense to add "new lag" info I
if we don't want to do that since it's rather redundant info.
> >
> > Thanks again.
> > --Vahid
> >
> >
> >
> > From: Jorge Esteban Quilcate Otoya
> > To: dev@kafka.apache.org
> > Date: 02/24/2017 12:47 PM
> > Subjec
erstand
> if we don't want to do that since it's rather redundant info.
>
> Thanks again.
> --Vahid
>
>
>
> From: Jorge Esteban Quilcate Otoya
> To: dev@kafka.apache.org
> Date: 02/24/2017 12:47 PM
> Subject:Re: KIP-122: Add a tool to Reset C
erstand
if we don't want to do that since it's rather redundant info.
Thanks again.
--Vahid
From: Jorge Esteban Quilcate Otoya
To: dev@kafka.apache.org
Date: 02/24/2017 12:47 PM
Subject: Re: KIP-122: Add a tool to Reset Consumer Group Offsets
Hi Vahid,
Thanks for y
Added to the KIP.
> Sorry for the delayed question/suggestion. I hope they make sense.
>
> Thanks.
> --Vahid
>
>
>
> From: Jorge Esteban Quilcate Otoya
> To: dev@kafka.apache.org
> Date: 02/24/2017 09:51 AM
> Subject:Re: KIP-122: Add a tool to
eban Quilcate Otoya
To: dev@kafka.apache.org
Date: 02/24/2017 09:51 AM
Subject:Re: KIP-122: Add a tool to Reset Consumer Group Offsets
Great! KIP updated.
El vie., 24 feb. 2017 a las 18:22, Matthias J. Sax
()
escribió:
> I like this!
>
> --by-duration and --shift-b
Great! KIP updated.
El vie., 24 feb. 2017 a las 18:22, Matthias J. Sax ()
escribió:
> I like this!
>
> --by-duration and --shift-by
>
>
> -Matthias
>
> On 2/24/17 12:57 AM, Jorge Esteban Quilcate Otoya wrote:
> > Renaming to --by-duration LGTM
> >
> > Not sure about changing it to --shift-by-du
I like this!
--by-duration and --shift-by
-Matthias
On 2/24/17 12:57 AM, Jorge Esteban Quilcate Otoya wrote:
> Renaming to --by-duration LGTM
>
> Not sure about changing it to --shift-by-duration because we could end up
> with the same redundancy as before with reset: --reset-offsets
> --reset
Renaming to --by-duration LGTM
Not sure about changing it to --shift-by-duration because we could end up
with the same redundancy as before with reset: --reset-offsets
--reset-to-*.
Maybe changing --shift-offset-by to --shift-by 'n' could make it consistent
enough?
El vie., 24 feb. 2017 a las 6
I just read the update KIP once more.
I would suggest to rename --to-duration to --by-duration
Or as a second idea, rename --to-duration to --shift-by-duration and at
the same time rename --shift-offset-by to --shift-by-offset
Not sure what the best option is, but naming would be more consistent
Hi All,
If there are no more concerns, I'd like to start vote for this KIP.
Thanks!
Jorge.
El jue., 23 feb. 2017 a las 22:50, Jorge Esteban Quilcate Otoya (<
quilcate.jo...@gmail.com>) escribió:
> Oh ok :)
>
> So, we can keep `--topic t1:1,2,3`
>
> I think with this one we have most of the feed
Oh ok :)
So, we can keep `--topic t1:1,2,3`
I think with this one we have most of the feedback applied. I will update
the KIP with this change.
El jue., 23 feb. 2017 a las 22:38, Matthias J. Sax ()
escribió:
> Sounds reasonable.
>
> If we have multiple --topic arguments, it does also not matter
Sounds reasonable.
If we have multiple --topic arguments, it does also not matter if we use
t1:1,2 or t2=1,2
I just suggested '=' because I wanted use ':' to chain multiple topics.
-Matthias
On 2/23/17 10:49 AM, Jorge Esteban Quilcate Otoya wrote:
> Yeap, `--topic t1=1,2`LGTM
>
> Don't have i
Yeap, `--topic t1=1,2`LGTM
Don't have idea neither about getting rid of repeated --topic, but --group
is also repeated in the case of deletion, so it could be ok to have
repeated --topic arguments.
El jue., 23 feb. 2017 a las 19:14, Matthias J. Sax ()
escribió:
> So you suggest to merge "scope o
So you suggest to merge "scope options" --topics, --topic, and
--partitions into a single option? Sound good to me.
I like the compact way to express it, ie, topicname:list-of-partitions
with "all partitions" if not partitions are specified. It's quite
intuitive to use.
Just wondering, if we coul
@Matthias about the point 9:
What about keeping only the --topic option, and support this format:
`--topic t1:0,1,2 --topic t2 --topic t3:2`
In this case topics t1, t2, and t3 will be selected: topic t1 with
partitions 0,1 and 2; topic t2 with all its partitions; and topic t3, with
only partitio
Thanks for the feedback Matthias.
* 1. You're right. I'll reorder the scenarios.
* 2. Agree. I'll update the KIP.
* 3. I like it, updating to `reset-offsets`
* 4. Agree, removing the `reset-` part
* 5. Yes, 1.e option without --execute or --export will print out current
offset, and the new off
Hi,
thanks for updating the KIP. Couple of follow up comments:
* Nit: Why is "Reset to Earliest" and "Reset to Latest" a "reset by
time" option -- IMHO it belongs to "reset by position"?
* Nit: Description of "Reset to Earliest"
> using Kafka Consumer's `auto.offset.reset` to `earliest`
I thi
Hi,
according to the feedback, I've updated the KIP:
- We have added and ordered the scenarios, scopes and executions of the
Reset Offset tool.
- Consider it as an extension to the current `ConsumerGroupCommand` tool
- Execution will be possible without generating JSON files.
https://cwiki.apach
Great. I think I got the idea. What about this options:
Scenarios:
1. Current status
´kafka-consumer-groups.sh --reset-offset --group cg1´
2. To Datetime
´kafka-consumer-groups.sh --reset-offset --group cg1 --reset-to-datetime
2017-01-01T00:00:00.000´
3. To Period
´kafka-consumer-groups.sh -
Yes - using a tool like this to skip a set of consumer groups over a
corrupt/bad message is definitely appealing.
B
On Wed, Feb 8, 2017 at 9:37 PM Gwen Shapira wrote:
> I like the --reset-to-earliest and --reset-to-latest. In general,
> since the JSON route is the most challenging for users, we
I like the --reset-to-earliest and --reset-to-latest. In general,
since the JSON route is the most challenging for users, we want to
provide a lot of ways to do useful things without going there.
Two things that can help:
1. A lot of times, users want to skip few messages that cause issues
and co
Thanks for the feedback!
@Onur, @Gwen:
Agree. Actually at the first draft I considered to have it inside
´kafka-consumer-groups.sh´, but I decide to propose it as a standalone tool
to describe it clearly and focus it on reset functionality.
But now that you mentioned, it does make sense to have
As long as the CLI is a bit consistent? Like, not just adding 3
arguments and a JSON parser to the existing tool, right?
On Tue, Feb 7, 2017 at 10:29 PM, Onur Karaman
wrote:
> I think it makes sense to just add the feature to kafka-consumer-groups.sh
>
> On Tue, Feb 7, 2017 at 10:24 PM, Gwen Shap
I think it makes sense to just add the feature to kafka-consumer-groups.sh
On Tue, Feb 7, 2017 at 10:24 PM, Gwen Shapira wrote:
> Thanks for the KIP. I'm super happy about adding the capability.
>
> I hate the interface, though. It looks exactly like the replica
> assignment tool. A tool everyon
Thanks for the KIP. I'm super happy about adding the capability.
I hate the interface, though. It looks exactly like the replica
assignment tool. A tool everyone loves so much that there are multiple
projects, open and closed, that try to fix it.
Can we swap it with something that looks a bit mor
Jorge,
can you please add your KIP to this table:
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals#KafkaImprovementProposals-KIPsunderdiscussion
Thanks!
-Matthias
On 2/7/17 9:29 PM, Matthias J. Sax wrote:
> Jorge,
>
> thanks for you KIP. I like it a lot and thin
I've been meaning to suggest something very similar to this KIP.
Something lacking in the KIP is under what scenarios the offset reset tool
will run. Are all members of the group expected to be offline or can we
override offsets while members of the group are live? This matters when
factoring in t
Jorge,
thanks for you KIP. I like it a lot and think it will be a nice addition!
-Matthias
On 2/7/17 7:04 PM, Dong Lin wrote:
> Hey Jorge,
>
> Thanks for the KIP. I have some quick comments:
>
> - Should we allow user to use wildcard to reset offset of all groups for a
> given topic as well?
Hey Jorge,
Thanks for the KIP. I have some quick comments:
- Should we allow user to use wildcard to reset offset of all groups for a
given topic as well?
- Should we allow user to specify timestamp per topic partition in the json
file as well?
- Should the script take some credential file to mak
Hi all,
I would like to propose a KIP to Add a tool to Reset Consumer Group Offsets.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-122%3A+Add+a+tool+to+Reset+Consumer+Group+Offsets
Please, take a look at the proposal and share your feedback.
Thanks,
Jorge.
32 matches
Mail list logo
