I've been meaning to suggest something very similar to this KIP. Something lacking in the KIP is under what scenarios the offset reset tool will run. Are all members of the group expected to be offline or can we override offsets while members of the group are live? This matters when factoring in the offset commit logic on the GroupCoordinator.
Currently the only way for an admin to successfully override offsets is if either: 1. they send an OffsetCommitRequest with generationId -1 and if the group is in the Empty state 2. they send an OffsetCommitRequest impersonating a member of the group with accurate generationId and memberId You can actually get away with overriding while members of the group are live with method 2 by using group information from DescribeGroupsRequest. On Tue, Feb 7, 2017 at 9:29 PM, Matthias J. Sax <matth...@confluent.io> wrote: > Jorge, > > thanks for you KIP. I like it a lot and think it will be a nice addition! > > > -Matthias > > > On 2/7/17 7:04 PM, Dong Lin wrote: > > Hey Jorge, > > > > Thanks for the KIP. I have some quick comments: > > > > - Should we allow user to use wildcard to reset offset of all groups for > a > > given topic as well? > > - Should we allow user to specify timestamp per topic partition in the > json > > file as well? > > - Should the script take some credential file to make sure that this > > operation is authenticated given the potential impact of this operation? > > - Should we provide constant to reset committed offset to earliest/latest > > offset of a partition, e.g. -1 indicates earliest offset > > and -2 indicates latest offset. > > - Should we allow dynamic change of the comitted offset when consumer are > > running, such that consumer will seek to the newly committed offset and > > start consuming from there? > > > > BTW, I guess more people just write their own program which starts a > > consumer and commits offset instead of re-deploying application as > > suggested in the motivation section. I agree that having a ready-to-use > > script will make it easier. > > > > Thanks, > > Dong > > > > > > On Tue, Feb 7, 2017 at 6:43 PM, Jorge Esteban Quilcate Otoya < > > quilcate.jo...@gmail.com> wrote: > > > >> Hi all, > >> > >> I would like to propose a KIP to Add a tool to Reset Consumer Group > >> Offsets. > >> > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-122% > >> 3A+Add+a+tool+to+Reset+Consumer+Group+Offsets > >> > >> Please, take a look at the proposal and share your feedback. > >> > >> Thanks, > >> Jorge. > >> > > > >
