Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2024-07-07 Thread Dongjin Lee
Hi all, I just filed KIP-1067: Remove ReplicaVerificationTool in 4.0 (deprecate in 3.9) . It replaces KIP-752, so let's continue on the new discussion & voting threads. Thanks, Dongjin On Sat, Jul 6, 2024 at 9:05 PM Dong

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2024-07-06 Thread Dongjin Lee
Hi Tsai, Great. I will close the old KIP & PR and file new ones by this weekend. Thanks, Dongjin On Thu, Jul 4, 2024 at 8:48 PM Chia-Ping Tsai wrote: > hi Dongjin > > I have assigned https://issues.apache.org/jira/browse/KAFKA-17073 to you. > thanks for you to take over it :) > > On 2024/07/04

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2024-07-04 Thread Chia-Ping Tsai
hi Dongjin I have assigned https://issues.apache.org/jira/browse/KAFKA-17073 to you. thanks for you to take over it :) On 2024/07/04 05:38:42 Dongjin Lee wrote: > Okay, Ismael's opinion seems reasonable, so I will follow it. > > Then, could you please assign me the deprecation issue & KIP? Sinc

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2024-07-03 Thread Dongjin Lee
Okay, Ismael's opinion seems reasonable, so I will follow it. Then, could you please assign me the deprecation issue & KIP? Since I opened this KIP in the past, I hope to wrap it up. If you are okay with it, I will close this issue & KIP and file the deprecation KIP instead. Thanks, Dongjin On T

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2024-07-03 Thread Chia-Ping Tsai
see https://issues.apache.org/jira/browse/KAFKA-17073 for deprecation. On 2024/07/03 14:57:51 Chia-Ping Tsai wrote: > Agree to Juma > > > Ismael Juma 於 2024年7月3日 晚上10:41 寫道: > > > > I think we should just do a KIP to remove it in 4.0 with deprecation in > > 3.9. > > > > Ismael > > > >> On

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2024-07-03 Thread Chia-Ping Tsai
Agree to Juma > Ismael Juma 於 2024年7月3日 晚上10:41 寫道: > > I think we should just do a KIP to remove it in 4.0 with deprecation in 3.9. > > Ismael > >> On Wed, Jul 3, 2024 at 7:38 AM Chia-Ping Tsai wrote: >> >> hi Dongjin >> >> It will be removed in 4.0 if we are able to deprecate it in 3.9.

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2024-07-03 Thread Ismael Juma
I think we should just do a KIP to remove it in 4.0 with deprecation in 3.9. Ismael On Wed, Jul 3, 2024 at 7:38 AM Chia-Ping Tsai wrote: > hi Dongjin > > It will be removed in 4.0 if we are able to deprecate it in 3.9. Hence, it > seems to me enhancing it is a bit weird since the feature is act

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2024-07-03 Thread Chia-Ping Tsai
hi Dongjin It will be removed in 4.0 if we are able to deprecate it in 3.9. Hence, it seems to me enhancing it is a bit weird since the feature is active only for one release … > > Dongjin Lee 於 2024年7月3日 晚上10:04 寫道: > > Hi Tsai, > > Sorry for being late. How about this way? > > 1. Amend

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2024-07-03 Thread Dongjin Lee
Hi Tsai, Sorry for being late. How about this way? 1. Amend mention on the deprecation plan to the original KIP. 2. You cast +1 to this voting thread. 3. Add a new KIP to remove this tool with the 4.0 release. Since this KIP already has +2 bindings with PR, this way would be slightly more swift.

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2024-06-02 Thread Chia-Ping Tsai
`replica_verification_test.py` is unstable in my jenkins, and then I notice this thread. Maybe kafka 4 is a good timing to remove this tool, but does it need a KIP? If so, I'd like to file a KIP for it. Best, Chia-Ping On 2021/06/10 05:01:43 Ismael Juma wrote: > KAFKA-12600 was a general chang

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-10-12 Thread Dongjin Lee
Bumping up the voting thread for the 3.1.0 KIP freeze deadline. As of present: Binding: +2 (Gwen, Randall) Non-binding: +1 (Luke) Please note that this tool is one of the only two that are omitted from the '--bootstrap-server' standard parameter. The other one is StreamsResetter, which uses '--b

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-21 Thread Dongjin Lee
Hi Guozhang, Thanks for the comment. I updated the KIP applying your comment. @All Any other thoughts? Regards, Dongjin On Tue, Jun 15, 2021 at 1:40 AM Guozhang Wang wrote: > If we believe this tool does not work anymore and there's other ways to > achieve the intended function, then we shou

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-14 Thread Guozhang Wang
If we believe this tool does not work anymore and there's other ways to achieve the intended function, then we should remove it in the next release; otherwise, I think this KIP still is worthy. In any ways, we should not left a cmd tool not maintained but not removed either. Guozhang On Thu, Jun

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-10 Thread Dongjin Lee
Hi Ismael, > I am not convinced this tool is actually useful, I haven't seen anyone using it in years. Sure, you may right indeed. The `ReplicaVerificationTool` may not be so useful.[^0] However, I hope to propose another perspective. As long as this tool is provided with a launcher script in a

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-09 Thread Ismael Juma
KAFKA-12600 was a general change, not related to this tool specifically. I am not convinced this tool is actually useful, I haven't seen anyone using it in years. Ismael On Wed, Jun 9, 2021 at 9:51 PM Dongjin Lee wrote: > Hi Ismael, > > Before I submit this KIP, I reviewed some history. When KI

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-09 Thread Dongjin Lee
Hi Ismael, Before I submit this KIP, I reviewed some history. When KIP-499 tried to resolve the inconsistencies between the command line tools, two tools were omitted, probably by mistake

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-09 Thread Ismael Juma
Hi Dongjin, Does this tool still work? I recall that there were some doubts about it and that's why it wasn't updated previously. Ismael On Sat, Jun 5, 2021 at 2:38 PM Dongjin Lee wrote: > Hi all, > > I'd like to call for a vote on KIP-752: Support --bootstrap-server in > ReplicaVerificationTo

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-09 Thread Randall Hauch
Thanks for the straightforward KIP, Dongjin. +1 (binding) Best regards, Randall On Wed, Jun 9, 2021 at 9:41 PM wenbing shen wrote: > Hi Dongjin, > Thanks for the KIP. > +1 (non-binding) > > Thanks. > Wenbing > > Dongjin Lee 于2021年6月10日周四 上午10:04写道: > > > Thanks, Gwen and Luke, > > > > As of

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-09 Thread wenbing shen
Hi Dongjin, Thanks for the KIP. +1 (non-binding) Thanks. Wenbing Dongjin Lee 于2021年6月10日周四 上午10:04写道: > Thanks, Gwen and Luke, > > As of present: > - binding: +1 (Gwen) > - non-binding: +1 (Luke) > > Anyone else? > > Regards, > Dongjin > > On Thu, Jun 10, 2021 at 1:24 AM Gwen Shapira > wrote:

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-09 Thread Dongjin Lee
Thanks, Gwen and Luke, As of present: - binding: +1 (Gwen) - non-binding: +1 (Luke) Anyone else? Regards, Dongjin On Thu, Jun 10, 2021 at 1:24 AM Gwen Shapira wrote: > +1 (binding) > > On Wed, Jun 9, 2021 at 8:28 AM Dongjin Lee wrote: > > > Bumping up the voting thread. > > > > Please note t

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-09 Thread Gwen Shapira
+1 (binding) On Wed, Jun 9, 2021 at 8:28 AM Dongjin Lee wrote: > Bumping up the voting thread. > > Please note that today is the KIP freeze day. +1 non-binding until now. > > Thanks, > Dongjin > > On Sun, Jun 6, 2021 at 4:10 PM Luke Chen wrote: > > > Hi Dongjin, > > Thanks for the KIP. > > +1 (

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-09 Thread Dongjin Lee
Bumping up the voting thread. Please note that today is the KIP freeze day. +1 non-binding until now. Thanks, Dongjin On Sun, Jun 6, 2021 at 4:10 PM Luke Chen wrote: > Hi Dongjin, > Thanks for the KIP. > +1 (non-binding) > > Thanks. > Luke > > On Sun, Jun 6, 2021 at 5:38 AM Dongjin Lee wrote:

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-06 Thread Luke Chen
Hi Dongjin, Thanks for the KIP. +1 (non-binding) Thanks. Luke On Sun, Jun 6, 2021 at 5:38 AM Dongjin Lee wrote: > Hi all, > > I'd like to call for a vote on KIP-752: Support --bootstrap-server in > ReplicaVerificationTool: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-752%3A+Suppo