Hi Guozhang, Thanks for the comment. I updated the KIP applying your comment.
@All Any other thoughts? Regards, Dongjin On Tue, Jun 15, 2021 at 1:40 AM Guozhang Wang <wangg...@gmail.com> wrote: > If we believe this tool does not work anymore and there's other ways to > achieve the intended function, then we should remove it in the next > release; otherwise, I think this KIP still is worthy. In any ways, we > should not left a cmd tool not maintained but not removed either. > > Guozhang > > On Thu, Jun 10, 2021 at 10:05 PM Dongjin Lee <dong...@apache.org> wrote: > > > Hi Ismael, > > > > > I am not convinced this tool is actually useful, I haven't seen anyone > > using it in years. > > > > Sure, you may right indeed. The `ReplicaVerificationTool` may not be so > > useful.[^0] However, I hope to propose another perspective. > > > > As long as this tool is provided with a launcher script in a > distribution, > > its command-line parameters look so weird to the users since it breaks > > consistency. It is even worse with KIP-499 > > < > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=123899170 > > >[^1], > > which tries to unify the command line parameters and deprecate old ones - > > even the tools without launcher script (e.g., VerifiableLog4jAppender) > now > > uses `--bootstrap-server` parameter. This situation is rather odd, isn't > > it? > > > > This improvement may not have a great value, but it may reduce > awkwardness > > from the user's viewpoint. > > > > Best, > > Dongjin > > > > [^0]: With my personal experience, I used it to validate the replication > > when working with a client so sensitive to replication missing, like a > > Semiconductor manufacturing company. > > [^1]: Somewhat strange, two omitted tools from KIP-499 > > < > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=123899170 > > > > > all have their own launcher script. > > > > On Thu, Jun 10, 2021 at 2:02 PM Ismael Juma <ism...@juma.me.uk> wrote: > > > > > KAFKA-12600 was a general change, not related to this tool > specifically. > > I > > > am not convinced this tool is actually useful, I haven't seen anyone > > using > > > it in years. > > > > > > Ismael > > > > > > On Wed, Jun 9, 2021 at 9:51 PM Dongjin Lee <dong...@apache.org> wrote: > > > > > > > Hi Ismael, > > > > > > > > Before I submit this KIP, I reviewed some history. When KIP-499 > > > > < > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-499+-+Unify+connection+name+flag+for+command+line+tool > > > > > > > > > tried to resolve the inconsistencies between the command line tools, > > two > > > > tools were omitted, probably by mistake. > > > > > > > > - KAFKA-12878: Support --bootstrap-server > > kafka-streams-application-reset > > > > <https://issues.apache.org/jira/browse/KAFKA-12878> > > > > - KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool > > > > <https://issues.apache.org/jira/browse/KAFKA-12899> (this one) > > > > > > > > And it seems like this tool is still working. The last update was > > > > KAFKA-12600 <https://issues.apache.org/jira/browse/KAFKA-12600> by > > you, > > > > which will also be included in this 3.0.0 release. It is why I > > determined > > > > that this tool is worth updating. > > > > > > > > Thanks, > > > > Dongjin > > > > > > > > On Thu, Jun 10, 2021 at 1:26 PM Ismael Juma <ism...@juma.me.uk> > wrote: > > > > > > > > > Hi Dongjin, > > > > > > > > > > Does this tool still work? I recall that there were some doubts > about > > > it > > > > > and that's why it wasn't updated previously. > > > > > > > > > > Ismael > > > > > > > > > > On Sat, Jun 5, 2021 at 2:38 PM Dongjin Lee <dong...@apache.org> > > wrote: > > > > > > > > > > > Hi all, > > > > > > > > > > > > I'd like to call for a vote on KIP-752: Support > --bootstrap-server > > in > > > > > > ReplicaVerificationTool: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-752%3A+Support+--bootstrap-server+in+ReplicaVerificationTool > > > > > > > > > > > > Best, > > > > > > Dongjin > > > > > > > > > > > > -- > > > > > > *Dongjin Lee* > > > > > > > > > > > > *A hitchhiker in the mathematical world.* > > > > > > > > > > > > > > > > > > > > > > > > *github: <http://goog_969573159/>github.com/dongjinleekr > > > > > > <https://github.com/dongjinleekr>keybase: > > > > > https://keybase.io/dongjinleekr > > > > > > <https://keybase.io/dongjinleekr>linkedin: > > > > > kr.linkedin.com/in/dongjinleekr > > > > > > <https://kr.linkedin.com/in/dongjinleekr>speakerdeck: > > > > > > speakerdeck.com/dongjin > > > > > > <https://speakerdeck.com/dongjin>* > > > > > > > > > > > > > > > > > > > > > > > -- > > > > *Dongjin Lee* > > > > > > > > *A hitchhiker in the mathematical world.* > > > > > > > > > > > > > > > > *github: <http://goog_969573159/>github.com/dongjinleekr > > > > <https://github.com/dongjinleekr>keybase: > > > https://keybase.io/dongjinleekr > > > > <https://keybase.io/dongjinleekr>linkedin: > > > kr.linkedin.com/in/dongjinleekr > > > > <https://kr.linkedin.com/in/dongjinleekr>speakerdeck: > > > > speakerdeck.com/dongjin > > > > <https://speakerdeck.com/dongjin>* > > > > > > > > > > > > > -- > > *Dongjin Lee* > > > > *A hitchhiker in the mathematical world.* > > > > > > > > *github: <http://goog_969573159/>github.com/dongjinleekr > > <https://github.com/dongjinleekr>keybase: > https://keybase.io/dongjinleekr > > <https://keybase.io/dongjinleekr>linkedin: > kr.linkedin.com/in/dongjinleekr > > <https://kr.linkedin.com/in/dongjinleekr>speakerdeck: > > speakerdeck.com/dongjin > > <https://speakerdeck.com/dongjin>* > > > > > -- > -- Guozhang > -- *Dongjin Lee* *A hitchhiker in the mathematical world.* *github: <http://goog_969573159/>github.com/dongjinleekr <https://github.com/dongjinleekr>keybase: https://keybase.io/dongjinleekr <https://keybase.io/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr <https://kr.linkedin.com/in/dongjinleekr>speakerdeck: speakerdeck.com/dongjin <https://speakerdeck.com/dongjin>*
