[jira] [Commented] (KAFKA-813) Minor cleanup in Controller

2013-03-22 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610431#comment-13610431 ] Jun Rao commented on KAFKA-813: --- Ok. That's fine then. One more comment: 31. PartitionStateM

[jira] [Commented] (KAFKA-813) Minor cleanup in Controller

2013-03-22 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610100#comment-13610100 ] Swapnil Ghike commented on KAFKA-813: - 30. port has been included to maintain consisten

[jira] [Commented] (KAFKA-813) Minor cleanup in Controller

2013-03-21 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609042#comment-13609042 ] Neha Narkhede commented on KAFKA-813: - +1 on patch v3 > Minor cleanup

[jira] [Commented] (KAFKA-813) Minor cleanup in Controller

2013-03-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609038#comment-13609038 ] Jun Rao commented on KAFKA-813: --- Thanks for patch v3. Looks good. Just one more comment: 30.

[jira] [Commented] (KAFKA-813) Minor cleanup in Controller

2013-03-20 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608462#comment-13608462 ] Neha Narkhede commented on KAFKA-813: - 1.1 Makes sense, we can just live with the exist

[jira] [Commented] (KAFKA-813) Minor cleanup in Controller

2013-03-20 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608130#comment-13608130 ] Swapnil Ghike commented on KAFKA-813: - A couple of comments/questions before uploading

[jira] [Commented] (KAFKA-813) Minor cleanup in Controller

2013-03-20 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607705#comment-13607705 ] Neha Narkhede commented on KAFKA-813: - Thanks for patch v2 - 1. KafkaController 1.1 Th

[jira] [Commented] (KAFKA-813) Minor cleanup in Controller

2013-03-20 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607697#comment-13607697 ] Jun Rao commented on KAFKA-813: --- Thanks for patch v2. Some more comments. 20. PartitionState

[jira] [Commented] (KAFKA-813) Minor cleanup in Controller

2013-03-19 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606678#comment-13606678 ] Neha Narkhede commented on KAFKA-813: - Correct, another way to do this is to defined a

[jira] [Commented] (KAFKA-813) Minor cleanup in Controller

2013-03-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606672#comment-13606672 ] Swapnil Ghike commented on KAFKA-813: - @Neha: 2. If the target state is not OfflinePart

[jira] [Commented] (KAFKA-813) Minor cleanup in Controller

2013-03-19 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606649#comment-13606649 ] Neha Narkhede commented on KAFKA-813: - Thanks for the cleanup patch, Swapnil. Here are

[jira] [Commented] (KAFKA-813) Minor cleanup in Controller

2013-03-19 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606514#comment-13606514 ] Jun Rao commented on KAFKA-813: --- Thanks for the patch. Some comments: 1. For 1 and 2, it see