[jira] [Commented] (KAFKA-649) Cleanup log4j logging

2013-08-19 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13743888#comment-13743888 ] Jun Rao commented on KAFKA-649: --- Thanks for patch v6. Committed to 0.8. > Cl

[jira] [Commented] (KAFKA-649) Cleanup log4j logging

2013-08-02 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13727846#comment-13727846 ] Jun Rao commented on KAFKA-649: --- Thanks for patch v5. 50. ConsoleConsumer: There is no need

[jira] [Commented] (KAFKA-649) Cleanup log4j logging

2013-07-31 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13725485#comment-13725485 ] Guozhang Wang commented on KAFKA-649: - Thanks for the comments Jun. 30,31,32,33. Done.

[jira] [Commented] (KAFKA-649) Cleanup log4j logging

2013-07-31 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13725351#comment-13725351 ] Jun Rao commented on KAFKA-649: --- Thanks for patch v3. 30. KafkaApi.readMessageSets(): We don

[jira] [Commented] (KAFKA-649) Cleanup log4j logging

2013-05-29 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13669440#comment-13669440 ] Jun Rao commented on KAFKA-649: --- Thanks for the review. Addressed the comment and committed t

[jira] [Commented] (KAFKA-649) Cleanup log4j logging

2013-05-29 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13669433#comment-13669433 ] Neha Narkhede commented on KAFKA-649: - Actually, there is another error message that ne

[jira] [Commented] (KAFKA-649) Cleanup log4j logging

2013-05-29 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13669426#comment-13669426 ] Neha Narkhede commented on KAFKA-649: - +1. Just one comment - KafkaApis: Can we please

[jira] [Commented] (KAFKA-649) Cleanup log4j logging

2013-04-10 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628447#comment-13628447 ] Swapnil Ghike commented on KAFKA-649: - In DefaultEventhandler, we have a few warn("Fail

[jira] [Commented] (KAFKA-649) Cleanup log4j logging

2013-04-09 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627279#comment-13627279 ] Neha Narkhede commented on KAFKA-649: - These are good changes. Few more suggestions -

[jira] [Commented] (KAFKA-649) Cleanup log4j logging

2013-04-09 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627211#comment-13627211 ] Jun Rao commented on KAFKA-649: --- Thanks for the review. Committed to 0.8 after addressing all

[jira] [Commented] (KAFKA-649) Cleanup log4j logging

2013-04-09 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626998#comment-13626998 ] Jay Kreps commented on KAFKA-649: - +1 A few minor issues: 1. Typo: "No broker is ISR is ali

[jira] [Commented] (KAFKA-649) Cleanup log4j logging

2013-01-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561902#comment-13561902 ] Neha Narkhede commented on KAFKA-649: - >From KAFKA-696 review - Looks like we haven't

[jira] [Commented] (KAFKA-649) Cleanup log4j logging

2013-01-16 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555150#comment-13555150 ] Jun Rao commented on KAFKA-649: --- I can take a look at this. > Cleanup log4j

[jira] [Commented] (KAFKA-649) Cleanup log4j logging

2013-01-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552283#comment-13552283 ] Neha Narkhede commented on KAFKA-649: - Jay, would you like to take this on ?