[
https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561902#comment-13561902
]
Neha Narkhede commented on KAFKA-649:
-------------------------------------
>From KAFKA-696 review -
Looks like we haven't standardized StopReplicaRequest to use TopicAndPartition
instead of a custom Tuple for representing partitions. This messes up the log4j
logging style and the toString() API will not print partitions the way rest of
the code does. You can either include it in your patch or leave it for KAFKA-649
> Cleanup log4j logging
> ---------------------
>
> Key: KAFKA-649
> URL: https://issues.apache.org/jira/browse/KAFKA-649
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.8
> Reporter: Jay Kreps
> Assignee: Jun Rao
> Priority: Blocker
> Labels: p4
>
> Review the logs and do the following:
> 1. Fix confusing or duplicative messages
> 2. Assess that messages are at the right level (TRACE/DEBUG/INFO/WARN/ERROR)
> It would also be nice to add a log4j logger for the request logging (i.e. the
> access log) and another for the controller state change log, since these
> really have their own use cases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
