[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13791171#comment-13791171
]
Jun Rao commented on KAFKA-1008:
Thanks for the patch for trunk. +1.
> Unmap before resiz
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774698#comment-13774698
]
Jun Rao commented on KAFKA-1008:
Sorry, I missed that comment. +1 on v8.
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774684#comment-13774684
]
Jay Kreps commented on KAFKA-1008:
--
Sriram had the same comment. It is possible to reason
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774619#comment-13774619
]
Jun Rao commented on KAFKA-1008:
Thanks for patch v8. Just one more comment.
80. OffsetIn
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774241#comment-13774241
]
Elizabeth Wei commented on KAFKA-1008:
--
Sorry - I am not as active on this at the mom
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773517#comment-13773517
]
Sriram Subramanian commented on KAFKA-1008:
---
+1
> Unmap before
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773504#comment-13773504
]
Jay Kreps commented on KAFKA-1008:
--
Jun, added private on that method. Not sure about cyg
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773503#comment-13773503
]
Jay Kreps commented on KAFKA-1008:
--
Sriram:
1.1 This is because this.mmap can be null so
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13772459#comment-13772459
]
Neha Narkhede commented on KAFKA-1008:
--
ping [~lizziew], [~jkreps]. Could you address
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765579#comment-13765579
]
Jun Rao commented on KAFKA-1008:
Thanks for the patch. Reviewed patch v7 for 0.8. Looks go
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754293#comment-13754293
]
David Lao commented on KAFKA-1008:
--
Thanks Jay. The 0.8 patch seems to be working on Wind
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753311#comment-13753311
]
Sriram Subramanian commented on KAFKA-1008:
---
Looks good.
1. OffsetIndex.scala
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13750558#comment-13750558
]
David Lao commented on KAFKA-1008:
--
Hi Jay,
The master branch seems to be broken on Windo
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13748384#comment-13748384
]
Elizabeth Wei commented on KAFKA-1008:
--
I generated a patch against the trunk to fix
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13748206#comment-13748206
]
David Lao commented on KAFKA-1008:
--
Hi Jay,
The patch does not seem to apply cleanly on t
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746866#comment-13746866
]
Elizabeth Wei commented on KAFKA-1008:
--
The code change looks good. Using a higher or
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746719#comment-13746719
]
Timothy Chen commented on KAFKA-1008:
-
I wonder if this patch can go in soon? It's a m
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13742853#comment-13742853
]
Elizabeth Wei commented on KAFKA-1008:
--
Thanks Jay!
Please review the patch to see if
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13742391#comment-13742391
]
Jay Kreps commented on KAFKA-1008:
--
I think it makes sense to do it as part of this patch
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741938#comment-13741938
]
Elizabeth Wei commented on KAFKA-1008:
--
Sounds like a good idea to have lock reads. D
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741037#comment-13741037
]
Jay Kreps commented on KAFKA-1008:
--
Here is a list of os.name values (at least according
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741035#comment-13741035
]
Jay Kreps commented on KAFKA-1008:
--
Yeah, the problem is reads continue while the log is
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13740742#comment-13740742
]
Elizabeth Wei commented on KAFKA-1008:
--
That's right, the duplicate is a shallow copy
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13740611#comment-13740611
]
Jay Kreps commented on KAFKA-1008:
--
But my understanding is that these copies are just co
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13739926#comment-13739926
]
Elizabeth Wei commented on KAFKA-1008:
--
Thanks, I added the try/catch to handle the e
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13739197#comment-13739197
]
Jay Kreps commented on KAFKA-1008:
--
Hey Elizabeth, thanks for the patch.
Two issues.
Th
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13739105#comment-13739105
]
Elizabeth Wei commented on KAFKA-1008:
--
Thanks for the feedback!
1 - Currently tryUn
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13738373#comment-13738373
]
Jay Kreps commented on KAFKA-1008:
--
Hey Elizabeth, thanks for the patch!
Three follow-up
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737845#comment-13737845
]
Elizabeth Wei commented on KAFKA-1008:
--
For non Sun JVM environments, tryUnmap is no-
[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737841#comment-13737841
]
Guozhang Wang commented on KAFKA-1008:
--
Will this patch restrict to Sun JVM-only envi
30 matches
Mail list logo
