[
https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13748206#comment-13748206
]
David Lao commented on KAFKA-1008:
----------------------------------
Hi Jay,
The patch does not seem to apply cleanly on the 0.8 branch (see below). Can you
look into generating a new patch for 0.8?
git apply --check KAFKA-1008-v6.patch
error: patch failed: core/src/main/scala/kafka/log/OffsetIndex.scala:52
error: core/src/main/scala/kafka/log/OffsetIndex.scala: patch does not apply
error: patch failed: core/src/main/scala/kafka/utils/Utils.scala:21
error: core/src/main/scala/kafka/utils/Utils.scala: patch does not apply
error: patch failed: core/src/test/scala/unit/kafka/utils/UtilsTest.scala:18
error: core/src/test/scala/unit/kafka/utils/UtilsTest.scala: patch does not
apply
> Unmap before resizing
> ---------------------
>
> Key: KAFKA-1008
> URL: https://issues.apache.org/jira/browse/KAFKA-1008
> Project: Kafka
> Issue Type: Bug
> Components: core, log
> Affects Versions: 0.8
> Environment: Windows, Linux, Mac OS
> Reporter: Elizabeth Wei
> Assignee: Jay Kreps
> Labels: patch
> Fix For: 0.8
>
> Attachments: KAFKA-1008-v6.patch, unmap-v5.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> While I was studying how MappedByteBuffer works, I saw a sharing runtime
> exception on Windows. I applied what I learned to generate a patch which uses
> an internal open JDK API to solve this problem.
> Following Jay's advice, I made a helper method called tryUnmap().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
