回复:回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-05-29 Thread feyman2009
. Please let me know if you have any concerns, thanks a lot! Feyman -- 发件人:feyman2009 发送时间:2020年4月13日(星期一) 08:47 收件人:dev 主 题:回复:回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

回复:回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-12 Thread feyman2009
Thanks , John and Guochang! -- 发件人:Guozhang Wang 发送时间:2020年4月11日(星期六) 03:07 收件人:dev 主 题:Re: 回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter Thanks Feyman, I've looked at the update tha

Re: 回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-10 Thread Guozhang Wang
inding +1(Boyang, Sophie), I will mark it as > > approved and create a PR shortly. > > Thanks! > > > > Feyman > > -- > > 发件人:feyman2009 > > 发送时间:2020年4月8日(星期三) 14:21 > > 收件人:

Re: 回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-10 Thread John Roesler
> 收件人:dev ; Boyang Chen > 主 题:回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove > members in StreamsResetter > > Hi Boyang, > Thanks for reminding me of that! > I'm not sure about the convention, I thought it would need to > re-collect votes if the

回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-09 Thread feyman2009
) 14:21 收件人:dev ; Boyang Chen 主 题:回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter Hi Boyang, Thanks for reminding me of that! I'm not sure about the convention, I thought it would need to re-collect votes if the KIP has changed~ Let's

回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-07 Thread feyman2009
ks! Feyman -- 发件人:Boyang Chen 发送时间:2020年4月8日(星期三) 12:42 收件人:dev ; feyman2009 主 题:Re: 回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter You should already get enough votes if I'm counting corr

Re: 回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-07 Thread Boyang Chen
gt; >> 发件人:Boyang Chen > > >> 发送时间:2020年3月29日(星期日) 01:45 > > >> 收件人:dev ; feyman2009 > > >> 主 题:Re: 回复:回复:回复:[Vote] KIP-571: Add option to force remove members in > > StreamsResetter > > >> > > >> Hey Feyman, > > >> > > >> thanks for the update. I assume we would rely entirely on the in

回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-07 Thread feyman2009
s! Feyman -- 发件人:Boyang Chen 发送时间:2020年4月8日(星期三) 02:15 收件人:dev 主 题:Re: 回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter Hey Feyman, I think Matthias' suggestion is optional, and we could just use admin tool to remove single static m

Re: 回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-07 Thread Boyang Chen
Would you mind to elaborate why we still need that if we are > able to batch remove active members with adminClient? > > > > Thanks! > > > > Feyman > > ------------------ > > 发件人:Matthias J. Sax > > 发送时间:2020年4月7日(星期二) 08:25

Re: 回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-07 Thread Matthias J. Sax
members with adminClient? > > Thanks! > > Feyman > -- > 发件人:Matthias J. Sax > 发送时间:2020年4月7日(星期二) 08:25 > 收件人:dev > 主 题:Re: 回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in > StreamsReset

回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-07 Thread feyman2009
man -- 发件人:Matthias J. Sax 发送时间:2020年4月7日(星期二) 08:25 收件人:dev 主 题:Re: 回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter Overall LGTM. +1 (binding) So you do not plan so support removing a _single static_ member

Re: 回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-06 Thread Matthias J. Sax
间:2020年3月29日(星期日) 01:45 > 收件人:dev ; feyman2009 > 主 题:Re: 回复:回复:回复:[Vote] KIP-571: Add option to force remove members in > StreamsResetter > > Hey Feyman, > > thanks for the update. I assume we would rely entirely on the internal > changes for `removeMemberFromGroup` by

回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-30 Thread feyman2009
:[Vote] KIP-571: Add option to force remove members in StreamsResetter Hey Feyman, thanks for the update. I assume we would rely entirely on the internal changes for `removeMemberFromGroup` by sending a DescribeGroup request first. With that in mind, I don't think we need to add member.

Re: 回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-28 Thread Boyang Chen
收件人:dev > 主 题:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in > StreamsResetter > > Hi, team > I have updated the KIP-571 according to our latest discussion results, > would you mind to take a look? Thanks! > > Feyman > > >

回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-27 Thread feyman2009
Bump, can anyone kindly take a look at the updated KIP-571? Thanks! -- 发件人:feyman2009 发送时间:2020年3月23日(星期一) 08:51 收件人:dev 主 题:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter Hi, team I have

回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-22 Thread feyman2009
I will update the KIP shortly! Thanks! Feyman -- 发件人:Boyang Chen 发送时间:2020年3月14日(星期六) 00:39 收件人:dev 主 题:Re: 回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter Thanks Matthias and Guozhang

Re: 回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-18 Thread Boyang Chen
ugh to > describe the related results, is it make sense that we may remove > memberInfos in RemoveMembersFromConsumerGroupResult ? This KIP has no > dependency on this if we choose alternative 2) > > Could you advise? Thanks! > > Feyman > > > 送时间:2020年3月15日(星期

回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-18 Thread feyman2009
no dependency on this if we choose alternative 2) Could you advise? Thanks! Feyman 送时间:2020年3月15日(星期日) 10:11 收件人:dev 主 题:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter Hi, all Thanks a lot for your feedback! According to the discussion, it se

回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-14 Thread feyman2009
Thanks! Feyman -- 发件人:Boyang Chen 发送时间:2020年3月14日(星期六) 00:39 收件人:dev 主 题:Re: 回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter Thanks Matthias and Guozhang for the feedback. I'm not worrying too much

Re: 回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-13 Thread Boyang Chen
o you think? > > > => the comparison is to send a single "clear the group" request vs > > sending a "get members" + a "remove members" request since the > > adminClient.removeMembersFromConsumerGroup support batch removal. We > > don't ne

Re: 回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-12 Thread Guozhang Wang
uot;remove members" request since the > adminClient.removeMembersFromConsumerGroup support batch removal. We > don't need to send lots of leaveGroup requests for every single member. > > > > I can understand your point, but I think we could reuse the > current &g

Re: 回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-12 Thread Matthias J. Sax
t currently only support static member removal and this KIP-571 enables dynamic member removal for it, which is also consistent with the broker side logic. Users could get the member.id (and group.instance.id if for static member) by adminClient.describeConsumerGroups. > > Furthermore, I don't have an assumption that a consumer group should contain only static

回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-11 Thread feyman2009
> >> Thanks, +1 from me (binding). >> >> On Tue, Mar 3, 2020 at 9:39 PM feyman2009 >> wrote: >> >>> Hi, Guozhang Thanks a lot for the advice, that make sense! I >>> have updated the KIP page with the operational steps of >>> StreamsResetter. >>> >>> Thanks! Feyman >>>

Re: 回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-09 Thread Sophie Blee-Goldman
only static or dynamic members, and I think KIP-345 and this KIP > don't need to be based on this assumption. > You could correct me if I have the wrong understanding :) > > Thanks! > Feyman > > > > > > > > ---

回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-07 Thread feyman2009
or dynamic members, and I think KIP-345 and this KIP don't need to be based on this assumption. You could correct me if I have the wrong understanding :) Thanks! Feyman ------------------------------ 发件人:Matthias J. Sax 发送时间:2020年3月6日(星期五) 02:20 收件人:

Re: 回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-05 Thread Matthias J. Sax
------------------------ >>> >>> 发件人:Guozhang Wang >>> 发送时间:2020年3月3日(星期二) 14:22 收件人:dev ; >>> feyman2009 主 题:Re: 回复:回复:[Vote] >>> KIP-571: Add option to force remove members in StreamsResetter >>> >>> Hello Feyman, thanks

Re: 回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-05 Thread Bill Bejeck
actually need 3 binding votes for the KIP to pass. Please > > feel free to keep bumping the thread until some more committers can take > a > > look. > > > > By the way, you can totally start a PR, but we can’t merge it until the > > KIP passes the vote. > > > > Thanks! > > Joh

Re: 回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-03 Thread Guozhang Wang
; Thanks! > Feyman > > -- > 发件人:Guozhang Wang > 发送时间:2020年3月3日(星期二) 14:22 > 收件人:dev ; feyman2009 > 主 题:Re: 回复:回复:[Vote] KIP-571: Add option to force remove members in > StreamsResetter > > Hello Feyman, thanks for the proposal! > > I read th

回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-03 Thread feyman2009
:Re: 回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter Hello Feyman, thanks for the proposal! I read through the doc and overall it looks good to me. One minor thing I'd still like to point out is that, the "removeMembersFromConsumerGroup" only send

Re: 回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-02 Thread Guozhang Wang
- > 发件人:John Roesler > 发送时间:2020年3月2日(星期一) 22:00 > 收件人:dev > 主 题:Re: 回复:回复:[Vote] KIP-571: Add option to force remove members in > StreamsResetter > > Hi Feyman, > > Sorry, but we actually need 3 binding votes for the KIP to pass. Please >

回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-02 Thread feyman2009
hanks! > Feyman > > > -- > 发件人:Sophie Blee-Goldman > 发送时间:2020年2月28日(星期五) 10:17 > 收件人:dev > 主 题:Re: 回复:[Vote] KIP-571: Add option to force remove members in > StreamsResetter > > Thanks for the KIP, +1 (non-binding) > > On Thu, Feb 27, 2020

Re: 回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-02 Thread John Roesler
件人:Sophie Blee-Goldman > 发送时间:2020年2月28日(星期五) 10:17 > 收件人:dev > 主 题:Re: 回复:[Vote] KIP-571: Add option to force remove members in > StreamsResetter > > Thanks for the KIP, +1 (non-binding) > > On Thu, Feb 27, 2020 at 12:40 PM Boyang Chen > wrote: > > > Thank

回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-01 Thread feyman2009
e/display/KAFKA/KIP-571%3A+Add+option+to+force+remove+members+in+StreamsResetter > > > > > > > > > ------------------ > > > 发件人:feyman2009 > > > 发送时间:2020年2月27日(星期四) 09:38 > > > 收件人:dev > > > 主 题:[Vote] KIP-571: Add option to force remove member

Re: 回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-02-27 Thread Sophie Blee-Goldman
-------------------- > > > 发件人:feyman2009 > > > 发送时间:2020年2月27日(星期四) 09:38 > > > 收件人:dev > > > 主 题:[Vote] KIP-571: Add option to force remove members in > StreamsResetter > > > > > > > > > Hi, all > > > I would like to start a vote on KIP-571: Add option to force remove > > > members in StreamsResetter . > > > > > > Thanks! > > > Feyman > > > > > > > > >

Re: 回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-02-27 Thread Boyang Chen
onfluence/display/KAFKA/KIP-571%3A+Add+option+to+force+remove+members+in+StreamsResetter > > > > > > -- > > 发件人:feyman2009 > > 发送时间:2020年2月27日(星期四) 09:38 > > 收件人:dev > > 主 题:[Vote] KI

Re: 回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-02-27 Thread John Roesler
amsResetter > > > -- > 发件人:feyman2009 > 发送时间:2020年2月27日(星期四) 09:38 > 收件人:dev > 主 题:[Vote] KIP-571: Add option to force remove members in StreamsResetter > > > Hi, all > I would like to start a vote on KIP-571: Add option to force remove

回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-02-26 Thread feyman2009
Updated with the KIP link: https://cwiki.apache.org/confluence/display/KAFKA/KIP-571%3A+Add+option+to+force+remove+members+in+StreamsResetter -- 发件人:feyman2009 发送时间:2020年2月27日(星期四) 09:38 收件人:dev 主 题:[Vote] KIP-571: Add option to

[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-02-26 Thread feyman2009
Hi, all I would like to start a vote on KIP-571: Add option to force remove members in StreamsResetter . Thanks! Feyman