Thanks for the KIP. +1 (binding). -Bill
On Wed, Mar 4, 2020 at 12:40 AM Guozhang Wang <wangg...@gmail.com> wrote: > Thanks, +1 from me (binding). > > On Tue, Mar 3, 2020 at 9:39 PM feyman2009 <feyman2...@aliyun.com> wrote: > > > Hi, Guozhang > > Thanks a lot for the advice, that make sense! > > I have updated the KIP page with the operational steps of > > StreamsResetter. > > > > Thanks! > > Feyman > > > > ------------------------------------------------------------------ > > 发件人：Guozhang Wang <wangg...@gmail.com> > > 发送时间：2020年3月3日(星期二) 14:22 > > 收件人：dev <dev@kafka.apache.org>; feyman2009 <feyman2...@aliyun.com> > > 主 题：Re: 回复：回复：[Vote] KIP-571: Add option to force remove members in > > StreamsResetter > > > > Hello Feyman, thanks for the proposal! > > > > I read through the doc and overall it looks good to me. > > > > One minor thing I'd still like to point out is that, the > > "removeMembersFromConsumerGroup" only sends a leave-group request to the > > coordinator to let it remove the member, however, if the member is still > > there alive and running then it would soon be notified that it is no > longer > > a legal member of the group via heartbeats, and then automatically tries > to > > re-join the group. So on the operational side, it is still required that > > the following steps: > > > > 1) first stop the consumers (of streams instances), wait until the > > shutdown is complete. > > 2) then use admin client in case the stopped consumers are still > > registered at the broker side and we do not want to wait for session > > timeout. > > > > Even with this KIP, people should still not skip step 1) above, since > > otherwise the consumers would re-connect and re-join the group > immediately > > still. > > > > In your doc you've already mentioned "Furthermore, users should make sure > > all the stream applications are shutdown when running StreamsResetter > with > > --force, otherwise it might trigger unexpected rebalance. " What I'd want > > to clarify is that no matter if "--force" option is enabled, this is > always > > the case that users should shutdown the streams instances first, and then > > use the streams resetter :) > > > > As long as that is clarified in the proposal documentation, I'm +1 on > this > > KIP. > > > > > > Thanks again for the contribution, > > Guozhang > > > > > > On Mon, Mar 2, 2020 at 6:31 AM feyman2009 <feyman2...@aliyun.com.invalid > > > > wrote: > > Hi, John > > Sorry, I have mistaken the KIP approval standard, anyway, I will > start > > the PR soon and waiting for more binding approvals. > > > > Thanks! > > Feyman > > > > > > ------------------------------------------------------------------ > > 发件人：John Roesler <vvcep...@apache.org> > > 发送时间：2020年3月2日(星期一) 22:00 > > 收件人：dev <dev@kafka.apache.org> > > 主 题：Re: 回复：回复：[Vote] KIP-571: Add option to force remove members in > > StreamsResetter > > > > Hi Feyman, > > > > Sorry, but we actually need 3 binding votes for the KIP to pass. Please > > feel free to keep bumping the thread until some more committers can take > a > > look. > > > > By the way, you can totally start a PR, but we can’t merge it until the > > KIP passes the vote. > > > > Thanks! > > John > > > > On Mon, Mar 2, 2020, at 00:24, feyman2009 wrote: > > > Hi,all > > > Since currently we have 1 binding and two non-binding +1, I will > > > update the KIP-571 as adopted and initiate a PR shortly > > > > > > Thanks! > > > Feyman > > > > > > > > > ------------------------------------------------------------------ > > > 发件人：Sophie Blee-Goldman <sop...@confluent.io> > > > 发送时间：2020年2月28日(星期五) 10:17 > > > 收件人：dev <dev@kafka.apache.org> > > > 主 题：Re: 回复：[Vote] KIP-571: Add option to force remove members in > > StreamsResetter > > > > > > Thanks for the KIP, +1 (non-binding) > > > > > > On Thu, Feb 27, 2020 at 12:40 PM Boyang Chen < > reluctanthero...@gmail.com > > > > > > wrote: > > > > > > > Thanks Feyman, +1 (non-binding) > > > > > > > > On Thu, Feb 27, 2020 at 9:25 AM John Roesler <vvcep...@apache.org> > > wrote: > > > > > > > > > Thanks for the proposal! > > > > > > > > > > I'm +1 (binding) > > > > > -John > > > > > > > > > > On Wed, Feb 26, 2020, at 19:41, feyman2009 wrote: > > > > > > Updated with the KIP link: > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-571%3A+Add+option+to+force+remove+members+in+StreamsResetter > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------ > > > > > > 发件人：feyman2009 <feyman2...@aliyun.com.INVALID> > > > > > > 发送时间：2020年2月27日(星期四) 09:38 > > > > > > 收件人：dev <dev@kafka.apache.org> > > > > > > 主 题：[Vote] KIP-571: Add option to force remove members in > > > > StreamsResetter > > > > > > > > > > > > > > > > > > Hi, all > > > > > > I would like to start a vote on KIP-571: Add option to force > > remove > > > > > > members in StreamsResetter . > > > > > > > > > > > > Thanks! > > > > > > Feyman > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > -- Guozhang > > > > > > > > -- > -- Guozhang >
