Re: [VOTE} KIP-733: change Kafka Streams default replication factor config

2021-05-05 Thread Matthias J. Sax
Thanks for your comments. I just updated the KIP slightly. IMHO, all raised points are already mentioned on the KIP. Let me know if you disagree and what details the KIP might lack? Happy to make adjustments. But it seems that we agree to move forward with the actual change. I am closing the VOT

Re: [VOTE} KIP-733: change Kafka Streams default replication factor config

2021-04-23 Thread Sophie Blee-Goldman
That's a good summary of the situation in my mind. Definitely +1 to highlighting each of these specifically in the KIP On Fri, Apr 23, 2021 at 6:19 PM Ismael Juma wrote: > Thanks for the comments. Is the following fair? > > 1. It's good that upgrades are not affected under normal circumstances a

Re: [VOTE} KIP-733: change Kafka Streams default replication factor config

2021-04-23 Thread Ismael Juma
Thanks for the comments. Is the following fair? 1. It's good that upgrades are not affected under normal circumstances and it mitigates the compatibility impact greatly. 2. We're saying that the previous behavior of defaulting to 1 is dangerous and we don't want to fallback to that. 3. The main mo

Re: [VOTE} KIP-733: change Kafka Streams default replication factor config

2021-04-20 Thread Sophie Blee-Goldman
FWIW if someone is deploying a new Streams application to production and they don't set this config, either because they are not reading the docs or they just forgot, then imo it's actually better for them to hit this exception and fail-fast if the brokers don't support it. Currently, the default

Re: [VOTE} KIP-733: change Kafka Streams default replication factor config

2021-04-19 Thread Matthias J. Sax
Thanks Ismael, just to clarify, any app that is running and is regularly upgraded is not affected: As pointed out in the KIP, if there is a running app that does not overwrite the default, and the app is upgraded, it won't be affected because the repartition/changelog topics already exist. Second

Re: [VOTE} KIP-733: change Kafka Streams default replication factor config

2021-04-18 Thread Ismael Juma
Is the following accurate? Do we have data that not many users would be affected? "We also believe that 2.3.0 broker a sufficiently old such that not too many user may be affected" I wonder if we should fallback to an actual value if the brokers are 2.3.x or older. Ismael

Re: [VOTE} KIP-733: change Kafka Streams default replication factor config

2021-04-18 Thread Luke Chen
Hi Matthias, +1 (non-binding) Thanks for the KIP. Luke On Fri, Apr 16, 2021 at 3:32 PM Bruno Cadonna wrote: > Thanks Matthias, > > +1 (binding) > > Best, > Bruno > > On 16.04.21 01:03, Jorge Esteban Quilcate Otoya wrote: > > +1 > > > > Thanks Matthias! > > > > On Thu, 15 Apr 2021, 20:48 Israel

Re: [VOTE} KIP-733: change Kafka Streams default replication factor config

2021-04-16 Thread Bruno Cadonna
Thanks Matthias, +1 (binding) Best, Bruno On 16.04.21 01:03, Jorge Esteban Quilcate Otoya wrote: +1 Thanks Matthias! On Thu, 15 Apr 2021, 20:48 Israel Ekpo, wrote: Makes perfect sense to me +1 as well. Thanks Matthias. On Thu, Apr 15, 2021 at 2:41 PM Guozhang Wang wrote: +1 as well

Re: [VOTE} KIP-733: change Kafka Streams default replication factor config

2021-04-15 Thread Jorge Esteban Quilcate Otoya
+1 Thanks Matthias! On Thu, 15 Apr 2021, 20:48 Israel Ekpo, wrote: > Makes perfect sense to me > > +1 as well. > > Thanks Matthias. > > > On Thu, Apr 15, 2021 at 2:41 PM Guozhang Wang wrote: > > > +1 as well. Thanks! > > > > On Wed, Apr 14, 2021 at 4:30 PM Bill Bejeck wrote: > > > > > Thanks

Re: [VOTE} KIP-733: change Kafka Streams default replication factor config

2021-04-15 Thread Israel Ekpo
Makes perfect sense to me +1 as well. Thanks Matthias. On Thu, Apr 15, 2021 at 2:41 PM Guozhang Wang wrote: > +1 as well. Thanks! > > On Wed, Apr 14, 2021 at 4:30 PM Bill Bejeck wrote: > > > Thanks for the KIP Matthias. > > > > +1 (binding) > > > > -Bill > > > > On Wed, Apr 14, 2021 at 7:06

Re: [VOTE} KIP-733: change Kafka Streams default replication factor config

2021-04-15 Thread Guozhang Wang
+1 as well. Thanks! On Wed, Apr 14, 2021 at 4:30 PM Bill Bejeck wrote: > Thanks for the KIP Matthias. > > +1 (binding) > > -Bill > > On Wed, Apr 14, 2021 at 7:06 PM Sophie Blee-Goldman > wrote: > > > Thanks Matthias. I'm +1 (binding) > > > > -Sophie > > > > On Wed, Apr 14, 2021 at 3:36 PM Matth

Re: [VOTE} KIP-733: change Kafka Streams default replication factor config

2021-04-14 Thread Bill Bejeck
Thanks for the KIP Matthias. +1 (binding) -Bill On Wed, Apr 14, 2021 at 7:06 PM Sophie Blee-Goldman wrote: > Thanks Matthias. I'm +1 (binding) > > -Sophie > > On Wed, Apr 14, 2021 at 3:36 PM Matthias J. Sax wrote: > > > Hi, > > > > Because this KIP is rather small, I would like to skip a dedi

Re: [VOTE} KIP-733: change Kafka Streams default replication factor config

2021-04-14 Thread Sophie Blee-Goldman
Thanks Matthias. I'm +1 (binding) -Sophie On Wed, Apr 14, 2021 at 3:36 PM Matthias J. Sax wrote: > Hi, > > Because this KIP is rather small, I would like to skip a dedicated > discussion thread and call for a vote right way. If there are any > concerns, we can just discuss on this vote thread:

[VOTE} KIP-733: change Kafka Streams default replication factor config

2021-04-14 Thread Matthias J. Sax
Hi, Because this KIP is rather small, I would like to skip a dedicated discussion thread and call for a vote right way. If there are any concerns, we can just discuss on this vote thread: https://cwiki.apache.org/confluence/display/KAFKA/KIP-733%3A+change+Kafka+Streams+default+replication+factor+