Hi Matthias, +1 (non-binding) Thanks for the KIP. Luke
On Fri, Apr 16, 2021 at 3:32 PM Bruno Cadonna <cado...@apache.org> wrote: > Thanks Matthias, > > +1 (binding) > > Best, > Bruno > > On 16.04.21 01:03, Jorge Esteban Quilcate Otoya wrote: > > +1 > > > > Thanks Matthias! > > > > On Thu, 15 Apr 2021, 20:48 Israel Ekpo, <israele...@gmail.com> wrote: > > > >> Makes perfect sense to me > >> > >> +1 as well. > >> > >> Thanks Matthias. > >> > >> > >> On Thu, Apr 15, 2021 at 2:41 PM Guozhang Wang <wangg...@gmail.com> > wrote: > >> > >>> +1 as well. Thanks! > >>> > >>> On Wed, Apr 14, 2021 at 4:30 PM Bill Bejeck <bbej...@gmail.com> wrote: > >>> > >>>> Thanks for the KIP Matthias. > >>>> > >>>> +1 (binding) > >>>> > >>>> -Bill > >>>> > >>>> On Wed, Apr 14, 2021 at 7:06 PM Sophie Blee-Goldman > >>>> <sop...@confluent.io.invalid> wrote: > >>>> > >>>>> Thanks Matthias. I'm +1 (binding) > >>>>> > >>>>> -Sophie > >>>>> > >>>>> On Wed, Apr 14, 2021 at 3:36 PM Matthias J. Sax <mj...@apache.org> > >>>> wrote: > >>>>> > >>>>>> Hi, > >>>>>> > >>>>>> Because this KIP is rather small, I would like to skip a dedicated > >>>>>> discussion thread and call for a vote right way. If there are any > >>>>>> concerns, we can just discuss on this vote thread: > >>>>>> > >>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-733%3A+change+Kafka+Streams+default+replication+factor+config > >>>>>> > >>>>>> Note, that we actually backed this change via > >>>>>> > >>>>> > >>>> > >>> > >> > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=113708722 > >>>>>> already. > >>>>>> > >>>>>> However, I felt it might be worth do make this change more explicit > >>> as > >>>>>> KIP-464 is rather old now. > >>>>>> > >>>>>> Quote from KIP-464: > >>>>>> > >>>>>>> To exploit this new feature in KafkaStreams, we update the > >> default > >>>>> value > >>>>>> of Streams configuration parameter `replication.factor` from `1` to > >>>> `-1`. > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> -Matthias > >>>>>> > >>>>> > >>>> > >>> > >>> > >>> -- > >>> -- Guozhang > >>> > >> > > >
