Hello everyone,
I'm ending this KIP vote as accepted with 4 binding +1s (John, Bruno,
David, Luke).
The wiki page has been updated and the corresponding code merged to trunk.
Thanks!
Guozhang
On Wed, Jul 6, 2022 at 7:02 PM Luke Chen wrote:
> Hi Guozhang,
>
> Removing the script-extention fro
Hi Guozhang,
Removing the script-extention from the KIP is good to me.
+1 from me, too.
Thank you.
Luke
On Thu, Jul 7, 2022 at 7:39 AM Guozhang Wang wrote:
> Hello folks,
>
> I tried to implement the script-extension along with the unit test coverage
> on DescribeConsumerGroupTest, but it turn
Hello folks,
I tried to implement the script-extension along with the unit test coverage
on DescribeConsumerGroupTest, but it turns out more complicated than I
anticipated due to the fact that we need to make sure the `require-stable`
flag is only effective for describing consumers. This also make
Hi,
I would prefer to not include the script-extension into the KIP if you
you cannot commit to its implementation. I think partially implemented
KIPs make release management harder. If we can avoid implementing KIPs
partially, we should do it.
I am +1 either way. I just wanted to bring this
Hi Guozhang,
> We can add it into this proposal though I could not commit to implementing
it myself with all the `DescribeConsumerGroupTest` coverage after it's
accepted, instead I could add a JIRA ticket under this KIP for others who's
interested to chime in. What do you think?
Sounds good to me
Thanks for folks for your input !
1) I'm happy to change the setter names to be consistent with the
topicPartition ones. I used a different name for getter from setter as I
remember seeing some other options differentiating function names for
getter and setters, while some other options seem to be
Hi Guozhang,
Thanks for the KIP!
I agree with Luke. `requireStable` seems more consistent.
Regarding the kafka-consumer-group command line tool, I wonder if
there is real value in doing it. We don't necessarily have to add all
the options to it but we could if it is proven to be useful. Anyway,
Hi Guozhang,
thank you for the KIP!
I do not have strong feelings about the naming of the getter, but I tend
to agree with Luke.
Regarding, the adaptation of the kafka-consumer-group.sh script, I am
fine if we leave that for a future KIP.
+1 (binding)
Best,
Bruno
On 01.07.22 06:05, Luke
Hi Guozhang,
Thanks for the KIP.
Some comments:
1. I have the same question as Ziming, should we also add an option in
kafka-consumer-groups.sh in this KIP?
Or you'd like to keep the current scope, and other people can create a
follow-up KIP to address the kafka-consumer-groups.sh script?
2. The s
Thanks for the KIP, Guozhang!
I’m +1 (binding)
-John
On Thu, Jun 30, 2022, at 21:17, deng ziming wrote:
> Thanks for this KIP,
> we have a kafka-consumer-groups.sh shell which is based on the API you
> proposed to change, is it worth update it as well?
>
> --
> Best,
> Ziming
>
>> On Jul 1, 202
Thanks for this KIP,
we have a kafka-consumer-groups.sh shell which is based on the API you proposed
to change, is it worth update it as well?
--
Best,
Ziming
> On Jul 1, 2022, at 9:04 AM, Guozhang Wang wrote:
>
> Hello folks,
>
> I'd like to call out for a vote for the following KIP to expos
Hello folks,
I'd like to call out for a vote for the following KIP to expose the
requireStable flag inside admin client's options as well:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-851%3A+Add+requireStable+flag+into+ListConsumerGroupOffsetsOptions
Any feedback as well as your votes a
12 matches
Mail list logo
