Re: [VOTE] KIP-815: Support max-timestamp in GetOffsetShell

Thank you David, I have already updated the KIP. The PR will be finished soon. -- Ziming Deng > On Feb 28, 2022, at 6:38 PM, David Jacot wrote: > > Thanks. Could you update the KIP to incorporate > Mickael's feedback? Ping me once the PR is > updated, I will finish reviewing it. > > Best, >

Re: [VOTE] KIP-815: Support max-timestamp in GetOffsetShell

Thanks. Could you update the KIP to incorporate Mickael's feedback? Ping me once the PR is updated, I will finish reviewing it. Best, David On Mon, Feb 28, 2022 at 11:33 AM deng ziming wrote: > > Hi all, > > Since it’s a pretty minor KIP, I think we can pass the vote with: > - 4 +1(binding) vote

Re: [VOTE] KIP-815: Support max-timestamp in GetOffsetShell

Hi all, Since it’s a pretty minor KIP, I think we can pass the vote with: - 4 +1(binding) votes (Luke, David, Mickael and John) Thanks to all that participated in the discussion and voting, -- Ziming Deng > On Feb 22, 2022, at 2:56 PM, David Jacot wrote: > > For reference, here is the KIP:

Re: [VOTE] KIP-815: Support max-timestamp in GetOffsetShell

Hello Maison, I think you suggestion makes sense, it’s better to support querying by "earliest" "latest" "max-timestamp”, I will add this to the KIP. > On Feb 23, 2022, at 8:54 PM, Mickael Maison wrote: > > Hi, > > I'm +1 (binding) too. > > Just one minor comment: > Could we make the "time"

Re: [VOTE] KIP-815: Support max-timestamp in GetOffsetShell

Thanks for the KIP, Ziming! I'm +1 (binding) -John On Wed, 2022-02-23 at 13:54 +0100, Mickael Maison wrote: > Hi, > > I'm +1 (binding) too. > > Just one minor comment: > Could we make the "time" argument also accept "earliest", "latest" and > "max-timestamp" alongside -1, -2, -3. I think it's

Re: [VOTE] KIP-815: Support max-timestamp in GetOffsetShell

Hi, I'm +1 (binding) too. Just one minor comment: Could we make the "time" argument also accept "earliest", "latest" and "max-timestamp" alongside -1, -2, -3. I think it's a bit confusing to use these negative numbers to specify the desired timestamps. Thanks On Tue, Feb 22, 2022 at 8:05 AM Luk

Re: [VOTE] KIP-815: Support max-timestamp in GetOffsetShell

Hi Ziming, Thanks for the KIP! I'm +1 (binding) Luke On Tue, Feb 22, 2022 at 2:56 PM David Jacot wrote: > For reference, here is the KIP: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-815%3A++Support+max-timestamp+in+GetOffsetShell > > Thanks for the KIP! +1 (binding) > > Best, > D

Re: [VOTE] KIP-815: Support max-timestamp in GetOffsetShell

For reference, here is the KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-815%3A++Support+max-timestamp+in+GetOffsetShell Thanks for the KIP! +1 (binding) Best, David Le mar. 22 févr. 2022 à 04:03, deng ziming a écrit : > Hey all, I'm starting the voting on KIP-815. > > This suppor

[VOTE] KIP-815: Support max-timestamp in GetOffsetShell

Hey all, I'm starting the voting on KIP-815. This supports a new OffsetSpec in GetOffsetShell so that we can easily determine the offset and timestamp of the message with the largest timestamp on a partition. This seems a simple change but replaced KafkaConsumer with AdminClient in GetOffsetShe

[VOTE] KIP-815: Support max-timestamp in GetOffsetShell

Thank you David, I retitled this KIP to be more accurate and supplemented the Compatibility and Rejected Alternatives sections, please help to review this again. Best, Ziming Deng > On Jan 31, 2022, at 6:12 PM, David Jacot wrote: > > Hey, > > Thanks for the KIP. I have a few comments: > > 1.