Hi, I'm +1 (binding) too.
Just one minor comment: Could we make the "time" argument also accept "earliest", "latest" and "max-timestamp" alongside -1, -2, -3. I think it's a bit confusing to use these negative numbers to specify the desired timestamps. Thanks On Tue, Feb 22, 2022 at 8:05 AM Luke Chen <show...@gmail.com> wrote: > > Hi Ziming, > > Thanks for the KIP! > I'm +1 (binding) > > Luke > > On Tue, Feb 22, 2022 at 2:56 PM David Jacot <david.ja...@gmail.com> wrote: > > > For reference, here is the KIP: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-815%3A++Support+max-timestamp+in+GetOffsetShell > > > > Thanks for the KIP! +1 (binding) > > > > Best, > > David > > > > Le mar. 22 févr. 2022 à 04:03, deng ziming <dengziming1...@gmail.com> a > > écrit : > > > > > Hey all, I'm starting the voting on KIP-815. > > > > > > This supports a new OffsetSpec in GetOffsetShell so that we can easily > > > determine the offset and timestamp of the message with the largest > > > timestamp on a partition. This seems a simple change but replaced > > > KafkaConsumer with AdminClient in GetOffsetShell. > > > > > > I recreated this vote thread since I changed the KIP title when > > > discussing. > > > > > > Thanks, > > > Ziming Deng > >
