Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

Hi Kirk, Thanks for bringing this to my attention! I hadn't found KAFKA-12841 previously, and so I had created KAFKA-13448 (a duplicate issue) and an associated PR back in November. I was told to create a KIP as it was a change in behaviour, and that's the reason for this KIP. PR #11689 implement

Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

Hi Seamus, Is there a conflict between KIP-799 and KAFKA-12841 ? A related fix for the latter issue was just merged a few days ago (https://github.com/apache/kafka/pull/11689) and it seems like there's some overlap or discrepancy between the t

Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

Hi all, Bumping this thread again. Kind reminder that* this KIP addresses a* *bug in the Kafka producer client*, where the implemented behaviour of the producer client is not the same as the documented behaviour in the case of callbacks. This has caused production incidents 'in the wild'. Regard

Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

Hi all, Bumping this voting thread, as it still needs one more binding vote to pass. Regards, Séamus. On Mon, 6 Dec 2021 at 12:04, Mickael Maison wrote: > Thanks for the KIP! > +1 (binding) > > On Sat, Dec 4, 2021 at 3:49 AM Luke Chen wrote: > > > > Hi Séamus, > > > > Thanks for the update. >

Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

Thanks for the KIP! +1 (binding) On Sat, Dec 4, 2021 at 3:49 AM Luke Chen wrote: > > Hi Séamus, > > Thanks for the update. > Looks better now! > > Thank you. > Luke > > On Sat, Dec 4, 2021 at 12:57 AM Séamus Ó Ceanainn < > seamus.oceana...@zalando.ie> wrote: > > > Hey Luke, > > > > Thanks for the

Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

Hi Séamus, Thanks for the update. Looks better now! Thank you. Luke On Sat, Dec 4, 2021 at 12:57 AM Séamus Ó Ceanainn < seamus.oceana...@zalando.ie> wrote: > Hey Luke, > > Thanks for the feedback. I've updated the relevant section to hopefully > make it more clear from the KIP itself what place

Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

Hey Luke, Thanks for the feedback. I've updated the relevant section to hopefully make it more clear from the KIP itself what placeholder value would be returned. Regards, Séamus. On Tue, 30 Nov 2021 at 09:52, Luke Chen wrote: > Hi Séamus, > Thanks for the KIP! > We definitely want to keep the

Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

Hi Séamus, Thanks for the KIP! We definitely want to keep the producer callback consistent for all types of errors. Just one comment for the KIP: In the "Proposed Changes" section, could you please "explicitly" describe what placeholder you'll return, in addition to adding a hyperlink to other pla

Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

Thanks, Séamus! I'm +1 (binding). On Mon, 2021-11-29 at 16:14 +, Séamus Ó Ceanainn wrote: > Hi everyone, > > I'd like to start a vote for KIP-799: Align behaviour for producer > callbacks with documented behaviour >

[VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

Hi everyone, I'd like to start a vote for KIP-799: Align behaviour for producer callbacks with documented behaviour . The KIP proposes a breaking change in the behaviour