Hi all, Bumping this thread again.
Kind reminder that* this KIP addresses a* *bug in the Kafka producer client*, where the implemented behaviour of the producer client is not the same as the documented behaviour in the case of callbacks. This has caused production incidents 'in the wild'. Regards, Séamus. On Tue, 25 Jan 2022 at 11:41, Séamus Ó Ceanainn <seamus.oceana...@zalando.ie> wrote: > Hi all, > > Bumping this voting thread, as it still needs one more binding vote to > pass. > > Regards, > Séamus. > > On Mon, 6 Dec 2021 at 12:04, Mickael Maison <mickael.mai...@gmail.com> > wrote: > >> Thanks for the KIP! >> +1 (binding) >> >> On Sat, Dec 4, 2021 at 3:49 AM Luke Chen <show...@gmail.com> wrote: >> > >> > Hi Séamus, >> > >> > Thanks for the update. >> > Looks better now! >> > >> > Thank you. >> > Luke >> > >> > On Sat, Dec 4, 2021 at 12:57 AM Séamus Ó Ceanainn < >> > seamus.oceana...@zalando.ie> wrote: >> > >> > > Hey Luke, >> > > >> > > Thanks for the feedback. I've updated the relevant section to >> hopefully >> > > make it more clear from the KIP itself what placeholder value would be >> > > returned. >> > > >> > > Regards, >> > > Séamus. >> > > >> > > On Tue, 30 Nov 2021 at 09:52, Luke Chen <show...@gmail.com> wrote: >> > > >> > > > Hi Séamus, >> > > > Thanks for the KIP! >> > > > We definitely want to keep the producer callback consistent for all >> types >> > > > of errors. >> > > > >> > > > Just one comment for the KIP: >> > > > In the "Proposed Changes" section, could you please "explicitly" >> describe >> > > > what placeholder you'll return, in addition to adding a hyperlink to >> > > other >> > > > places, to make it clear. >> > > > >> > > > +1 (non-binding) >> > > > >> > > > Thank you. >> > > > Luke >> > > > >> > > > On Tue, Nov 30, 2021 at 1:17 PM John Roesler <vvcep...@apache.org> >> > > wrote: >> > > > >> > > > > Thanks, Séamus! >> > > > > >> > > > > I'm +1 (binding). >> > > > > >> > > > > On Mon, 2021-11-29 at 16:14 +0000, Séamus Ó Ceanainn wrote: >> > > > > > Hi everyone, >> > > > > > >> > > > > > I'd like to start a vote for KIP-799: Align behaviour for >> producer >> > > > > > callbacks with documented behaviour >> > > > > > < >> > > > > >> > > > >> > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-799%3A+Align+behaviour+for+producer+callbacks+with+documented+behaviour >> > > > > > >> > > > > > . >> > > > > > >> > > > > > The KIP proposes a breaking change in the behaviour of producer >> > > client >> > > > > > callbacks. The breaking change would align the behaviour of >> callbacks >> > > > > with >> > > > > > the documented behaviour for the method, and makes it >> consistent with >> > > > > > similar methods for producer client interceptors. >> > > > > > >> > > > > > Regards, >> > > > > > Séamus. >> > > > > >> > > > > >> > > > >> > > >> >
