Re: [VOTE] KIP-749: Add --files and --file-separator options to the ConsoleProducer

Thanks, Boyang and Luke, As of present: - binding: +1 (Boyang) - non-binding: +1 (Luke) Can anyone else review this KIP? Regards, Wenbing On 2021/06/16 10:36:14, wenbing shen wrote: > Thanks for your comments Boyang. > > I updated the KIP to remove the code details you mentioned that are not

Re: [VOTE] KIP-749: Add --files and --file-separator options to the ConsoleProducer

Thanks for your comments Boyang. I updated the KIP to remove the code details you mentioned that are not necessary to be shown in the kip. And I submitted a PR for review: https://github.com/apache/kafka/pull/10889 Thanks, Wenbing Boyang Chen 于2021年6月12日周六 上午11:44写道： > Thanks for the updates

Re: [VOTE] KIP-749: Add --files and --file-separator options to the ConsoleProducer

Thanks for the updates Wenbing, the KIP looks good now. One suggestion would be removing the implementation details around "MessageReader" and "FileMessageReader" in the KIP, which should be reviewed in the actual PR. It's ok to briefly mention your high level approach in the `proposed changes` sec

Re: [VOTE] KIP-749: Add --files and --file-separator options to the ConsoleProducer

Thanks for your comments Ran. `kafka-console-producer.sh --broker-list localhost:9092 --topic my_topic <(cat file1 file2)` Does this command work properly? You are right, with the help of shell, we can also complete multi-file reading. In the windows environment, perhaps we will also use bat to c

Re: [VOTE] KIP-749: Add --files and --file-separator options to the ConsoleProducer

Thanks for your questions and comments Boyang. 1.Regarding the first point you mentioned: If we have some offline log files, we need to enter data into kafka for analysis and use in subsequent processes. This situation may not be frequent, but it does exist. After this KIP, these data can be writt

Re: [VOTE] KIP-749: Add --files and --file-separator options to the ConsoleProducer

kafka-console-producer.sh --broker-list localhost:9092 --topic my_topic <(cat file1 file2) בתאריך יום ב׳, 7 ביוני 2021, 05:05, מאת Ran Lupovich ‏: > kafka-console-producer.sh --broker-list localhost:9092 --topic my_topic < > my_file.txt > > > ? > > > בתאריך יום א׳, 6 ביוני 2021, 22:43, מאת Boya

Re: [VOTE] KIP-749: Add --files and --file-separator options to the ConsoleProducer

kafka-console-producer.sh --broker-list localhost:9092 --topic my_topic < my_file.txt ? בתאריך יום א׳, 6 ביוני 2021, 22:43, מאת Boyang Chen ‏< reluctanthero...@gmail.com>: > Thanks for the KIP Wenbing. I have a couple of questions: > > 1. Could you add more descriptions into the motivation sec

Re: [VOTE] KIP-749: Add --files and --file-separator options to the ConsoleProducer

Thanks for the KIP Wenbing. I have a couple of questions: 1. Could you add more descriptions into the motivation section, as of when the new options are favored and what's the current workaround? 2. Could you separate out the public interface and proposed changes sections, such that the new option

Re: [VOTE] KIP-749: Add --files and --file-separator options to the ConsoleProducer

Hi Wenbing, Thanks for the KIP! +1 (non-binding) Thanks. Luke On Sun, Jun 6, 2021 at 8:16 AM wenbing shen wrote: > Hi all, > > I'd like to start a vote on KIP-749 to add two options (--files and > --files-separator) to ConsoleProducer. > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP

[VOTE] KIP-749: Add --files and --file-separator options to the ConsoleProducer

Hi all, I'd like to start a vote on KIP-749 to add two options (--files and --files-separator) to ConsoleProducer. https://cwiki.apache.org/confluence/display/KAFKA/KIP-749:+Add+--files+and+--file-separator+options+to+the+ConsoleProducer Thanks, Wenbing