Thanks for the updates Wenbing, the KIP looks good now. One suggestion would be removing the implementation details around "MessageReader" and "FileMessageReader" in the KIP, which should be reviewed in the actual PR. It's ok to briefly mention your high level approach in the `proposed changes` section and no need to go deep, since this is not a major feature or architectural change.
Other than that, +1 (binding) from me. Boyang On Sun, Jun 6, 2021 at 10:54 PM wenbing shen <oliver.shen...@gmail.com> wrote: > Thanks for your comments Ran. > > `kafka-console-producer.sh --broker-list localhost:9092 --topic > my_topic <(cat file1 file2)` > Does this command work properly? > > You are right, with the help of shell, we can also complete multi-file > reading. > In the windows environment, perhaps we will also use bat to complete > multi-file reading. > Adding options from the producer command line tool to support this feature > is also to make it easier to use kafka. > > Thanks, > > Wenbing > > Ran Lupovich <ranlupov...@gmail.com> 于2021年6月7日周一 上午11:51写道： > > > kafka-console-producer.sh --broker-list localhost:9092 --topic > > my_topic <(cat file1 file2) > > > > בתאריך יום ב׳, 7 ביוני 2021, 05:05, מאת Ran Lupovich < > > ranlupov...@gmail.com > > >: > > > > > kafka-console-producer.sh --broker-list localhost:9092 --topic my_topic > > < my_file.txt > > > > > > > > > ? > > > > > > > > > בתאריך יום א׳, 6 ביוני 2021, 22:43, מאת Boyang Chen < > > > reluctanthero...@gmail.com>: > > > > > >> Thanks for the KIP Wenbing. I have a couple of questions: > > >> > > >> 1. Could you add more descriptions into the motivation section, as of > > when > > >> the new options are favored and what's the current workaround? > > >> 2. Could you separate out the public interface and proposed changes > > >> sections, such that the new options are put in the former section and > > the > > >> expected changes are in latter. > > >> 3. I don't see a necessity to add support for different file > separators, > > >> could you elaborate? > > >> > > >> Boyang > > >> > > >> On Sat, Jun 5, 2021 at 5:16 PM wenbing shen <oliver.shen...@gmail.com > > > > >> wrote: > > >> > > >> > Hi all, > > >> > > > >> > I'd like to start a vote on KIP-749 to add two options (--files and > > >> > --files-separator) to ConsoleProducer. > > >> > > > >> > > > >> > > > >> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-749:+Add+--files+and+--file-separator+options+to+the+ConsoleProducer > > >> > > > >> > Thanks, > > >> > > > >> > Wenbing > > >> > > > >> > > >> > > >
