Re: [VOTE] KIP-665 Kafka Connect Hash SMT

2020-12-16 Thread Brandon Brown
I’d like to give this one another friendly bump. If there are no disagreements I can update my existing Pr with the latest KIP changes. Thanks, -Brandon Brandon Brown > On Oct 26, 2020, at 8:29 PM, Brandon Brown wrote: > > I’ve update the KIP with suggestions from Gunnar. I’d like to bring

Re: [VOTE] KIP-665 Kafka Connect Hash SMT

2020-10-26 Thread Brandon Brown
I’ve update the KIP with suggestions from Gunnar. I’d like to bring this up for a vote. Brandon Brown > On Oct 22, 2020, at 12:53 PM, Brandon Brown wrote: > > Hey Gunnar, > > Those are great questions! > > 1) I went with it only selecting top level fields since it seems like that’s > the w

Re: [VOTE] KIP-665 Kafka Connect Hash SMT

2020-10-22 Thread Brandon Brown
Hey Gunnar, Those are great questions! 1) I went with it only selecting top level fields since it seems like that’s the way most of the out of the box SMTS work, however I could see a lot of value in it supporting nested fields. 2) I had not thought about adding salt but I think that would be

Re: [VOTE] KIP-665 Kafka Connect Hash SMT

2020-10-22 Thread Gunnar Morling
Hey Brandon, I think that's an interesting idea, we got something as a built-in connector feature in Debezium, too [1]. Two questions: * Can "field" select nested fields, e.g. "after.email"? * Did you consider an option for specifying salt for the hash functions? --Gunnar [1] https://debezium.i

Re: [VOTE] KIP-665 Kafka Connect Hash SMT

2020-10-22 Thread Brandon Brown
Gonna give this another little bump. :) Brandon Brown > On Oct 15, 2020, at 12:51 PM, Brandon Brown wrote: > >  > As I mentioned in the KIP, this transformer is slightly different from the > current MaskField SMT. > >> Currently there exists a MaskField SMT but that would completely remove

Re: [VOTE] KIP-665 Kafka Connect Hash SMT

2020-10-15 Thread Brandon Brown
As I mentioned in the KIP, this transformer is slightly different from the current MaskField SMT. > Currently there exists a MaskField SMT but that would completely remove the > value by setting it to an equivalent null value. One problem with this would > be that you’d not be able to know in

Re: [VOTE] KIP-665 Kafka Connect Hash SMT

2020-10-15 Thread Ning Zhang
Hello, I think this SMT feature is parallel to https://docs.confluent.io/current/connect/transforms/index.html On 2020/10/15 15:24:51, Brandon Brown wrote: > Bumping this thread. > Please take a look at the KIP and vote or let me know if you have any > feedback. > > KIP: > https://cwiki.apac

Re: [VOTE] KIP-665 Kafka Connect Hash SMT

2020-10-15 Thread Brandon Brown
Bumping this thread. Please take a look at the KIP and vote or let me know if you have any feedback. KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-665%3A+Kafka+Connect+Hash+SMT Proposed: https://github.com/apache/kafka/pull/9057 Thanks Brandon Brown > On Oct 8, 2020, at 10:30 PM,

Re: [VOTE] KIP-665 Kafka Connect Hash SMT

2020-10-08 Thread Brandon Brown
Just wanted to give another bump on this and see if anyone had any comments. Thanks! Brandon Brown > On Oct 1, 2020, at 9:11 AM, "bran...@bbrownsound.com" > wrote: > > Hey Kafka Developers, > > I’ve created the following KIP and updated it based on feedback from Mickael. > I was wondering

[VOTE] KIP-665 Kafka Connect Hash SMT

2020-10-01 Thread bran...@bbrownsound.com
Hey Kafka Developers, I’ve created the following KIP and updated it based on feedback from Mickael. I was wondering if we could get a vote on my proposal and move forward with the proposed pr. Thanks so much! -Brandon