Hey Colin,
Note that the clients expose "Map metrics()".
So, some things are already exposed. I generally agree that we should be
very clear about the new classes we are exposing as public APIs via this.
Ismael
On Mon, May 18, 2020 at 11:29 AM Colin McCabe wrote:
> KafkaMetrics isn't a public
Hi Zhiguo,
I think it's really important to distinguish between "a class being public" and
"a class being part of Kafka's public API." These really are two completely
different concepts, unfortunately.
The best explanation of interface annotations is probably here:
https://github.com/apache/k
The reason we have this KIP is that allow public AK to take advantage of
this such as AclAuthorizer.
Jeff
On Mon, May 18, 2020 at 11:29 AM Colin McCabe wrote:
> KafkaMetrics isn't a public API currently. Are we willing to make it
> one? I think this is a very big change, if so.
>
> This affect
Hi Ismael,
The purpose for this KIP allows plugins to use the same Metrics instance
from the broker without recreating it. Metrics is public class so we could
use it. Current Metrics is not implementing an interface related to any
metrics. Expose all fields through methods through interface is big
KafkaMetrics isn't a public API currently. Are we willing to make it one? I
think this is a very big change, if so.
This affects a huge number of classes. MetricConfig, MetricReporter,
MetricName, Sensor, KafkaMetric, and probably more I'm forgetting would need to
become public APIs that we
Hi Jeff,
I think the idea is good, but I have 2 questions/comments:
1. The monitor method is documented to "get" metrics, but it takes a
`Metrics` instance. Either the method name/signature needs to be adjusted
or the documentation.
2. Instead of exposing the Metrics class, which is currently not
+1 (binding)
Thanks for the KIP, Jeff!
Regards,
Rajini
On Mon, May 18, 2020 at 6:41 PM Jason Gustafson wrote:
> +1 This looks useful.
>
> -Jason
>
> On Mon, May 18, 2020 at 9:59 AM Guozhang Wang wrote:
>
> > Zhiguo, thanks for the KIP. +1 from me.
> >
> >
> > Guozhang
> >
> > On Fri, May 15,
+1 This looks useful.
-Jason
On Mon, May 18, 2020 at 9:59 AM Guozhang Wang wrote:
> Zhiguo, thanks for the KIP. +1 from me.
>
>
> Guozhang
>
> On Fri, May 15, 2020 at 2:21 PM Zhiguo Huang
> wrote:
>
> > Thanks to everyone for their input. I've incorporated the changes, and I
> > think this is
Zhiguo, thanks for the KIP. +1 from me.
Guozhang
On Fri, May 15, 2020 at 2:21 PM Zhiguo Huang
wrote:
> Thanks to everyone for their input. I've incorporated the changes, and I
> think this is ready for voting.
>
> To summarize, the KIP simply proposes to add a feature which expose
> instance o
Thanks to everyone for their input. I've incorporated the changes, and I
think this is ready for voting.
To summarize, the KIP simply proposes to add a feature which expose
instance of Kafka Metrics in Kafka Authorizer plugin.The KIP can be found
here:
https://cwiki.apache.org/confluence/display/K
10 matches
Mail list logo
