Hi Ismael, The purpose for this KIP allows plugins to use the same Metrics instance from the broker without recreating it. Metrics is public class so we could use it. Current Metrics is not implementing an interface related to any metrics. Expose all fields through methods through interface is big challenge. We do have scenarios that expose public class through interface.
Jeff. 11:if Metrics updated we have to update component to use it due to Metrics is public class On Mon, May 18, 2020 at 11:07 AM Ismael Juma <ism...@juma.me.uk> wrote: > Hi Jeff, > > I think the idea is good, but I have 2 questions/comments: > > 1. The monitor method is documented to "get" metrics, but it takes a > `Metrics` instance. Either the method name/signature needs to be adjusted > or the documentation. > 2. Instead of exposing the Metrics class, which is currently not exposed, I > think we should consider introducing an interface with the methods we want > to expose public. > > Ismael > > On Mon, May 18, 2020 at 10:47 AM Rajini Sivaram <rajinisiva...@gmail.com> > wrote: > > > +1 (binding) > > Thanks for the KIP, Jeff! > > > > Regards, > > > > Rajini > > > > > > On Mon, May 18, 2020 at 6:41 PM Jason Gustafson <ja...@confluent.io> > > wrote: > > > > > +1 This looks useful. > > > > > > -Jason > > > > > > On Mon, May 18, 2020 at 9:59 AM Guozhang Wang <wangg...@gmail.com> > > wrote: > > > > > > > Zhiguo, thanks for the KIP. +1 from me. > > > > > > > > > > > > Guozhang > > > > > > > > On Fri, May 15, 2020 at 2:21 PM Zhiguo Huang < > jeff.hu...@confluent.io> > > > > wrote: > > > > > > > > > Thanks to everyone for their input. I've incorporated the changes, > > and > > > I > > > > > think this is ready for voting. > > > > > > > > > > To summarize, the KIP simply proposes to add a feature which expose > > > > > instance of Kafka Metrics in Kafka Authorizer plugin.The KIP can be > > > found > > > > > here: > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-608+-+Expose+Kafka+Metrics+in+Authorizer > > > > > > > > > > Thanks a lot! > > > > > > > > > > Jeff. > > > > > > > > > > > > > > > > > -- > > > > -- Guozhang > > > > > > > > > >
