Re: [VOTE] KIP-4 Create Topics Schema

2016-06-23 Thread Grant Henke
Thanks to all who voted. The KIP-4 Create Topics changes passed with +4 (binding), and +4 (non-binding). There is a patch available for review here: https://github.com/apache/kafka/pull/1489 On Tue, Jun 21, 2016 at 1:11 AM, Manikumar Reddy wrote: > +1 (non-binding) > > On Tue, Jun 21, 2016 at 9

Re: [VOTE] KIP-4 Create Topics Schema

2016-06-20 Thread Manikumar Reddy
+1 (non-binding) On Tue, Jun 21, 2016 at 9:16 AM, Ewen Cheslack-Postava wrote: > +1 (binding) and thanks for the work on this Grant! > > -Ewen > > On Mon, Jun 20, 2016 at 12:18 PM, Gwen Shapira wrote: > > > +1 (binding) > > > > On Mon, Jun 20, 2016 at 12:13 PM, Tom Crayford > > wrote: > > > +1

Re: [VOTE] KIP-4 Create Topics Schema

2016-06-20 Thread Ewen Cheslack-Postava
+1 (binding) and thanks for the work on this Grant! -Ewen On Mon, Jun 20, 2016 at 12:18 PM, Gwen Shapira wrote: > +1 (binding) > > On Mon, Jun 20, 2016 at 12:13 PM, Tom Crayford > wrote: > > +1 (non-binding) > > > > On Mon, Jun 20, 2016 at 8:07 PM, Harsha wrote: > > > >> +1 (binding) > >> -Ha

Re: [VOTE] KIP-4 Create Topics Schema

2016-06-20 Thread Gwen Shapira
+1 (binding) On Mon, Jun 20, 2016 at 12:13 PM, Tom Crayford wrote: > +1 (non-binding) > > On Mon, Jun 20, 2016 at 8:07 PM, Harsha wrote: > >> +1 (binding) >> -Harsha >> >> On Mon, Jun 20, 2016, at 11:33 AM, Ismael Juma wrote: >> > +1 (binding) >> > >> > On Mon, Jun 20, 2016 at 8:27 PM, Dana Powe

Re: [VOTE] KIP-4 Create Topics Schema

2016-06-20 Thread Tom Crayford
+1 (non-binding) On Mon, Jun 20, 2016 at 8:07 PM, Harsha wrote: > +1 (binding) > -Harsha > > On Mon, Jun 20, 2016, at 11:33 AM, Ismael Juma wrote: > > +1 (binding) > > > > On Mon, Jun 20, 2016 at 8:27 PM, Dana Powers > > wrote: > > > > > +1 -- thanks for the update > > > > > > On Mon, Jun 20, 2

Re: [VOTE] KIP-4 Create Topics Schema

2016-06-20 Thread Harsha
+1 (binding) -Harsha On Mon, Jun 20, 2016, at 11:33 AM, Ismael Juma wrote: > +1 (binding) > > On Mon, Jun 20, 2016 at 8:27 PM, Dana Powers > wrote: > > > +1 -- thanks for the update > > > > On Mon, Jun 20, 2016 at 10:49 AM, Grant Henke wrote: > > > I have update the patch and wiki based on the

Re: [VOTE] KIP-4 Create Topics Schema

2016-06-20 Thread Ismael Juma
+1 (binding) On Mon, Jun 20, 2016 at 8:27 PM, Dana Powers wrote: > +1 -- thanks for the update > > On Mon, Jun 20, 2016 at 10:49 AM, Grant Henke wrote: > > I have update the patch and wiki based on the feedback in the discussion > > thread. The only change is that instead of logging and disconn

Re: [VOTE] KIP-4 Create Topics Schema

2016-06-20 Thread Dana Powers
+1 -- thanks for the update On Mon, Jun 20, 2016 at 10:49 AM, Grant Henke wrote: > I have update the patch and wiki based on the feedback in the discussion > thread. The only change is that instead of logging and disconnecting in the > case of invalid messages (duplicate topics or both arguments)

Re: [VOTE] KIP-4 Create Topics Schema

2016-06-20 Thread Grant Henke
I have update the patch and wiki based on the feedback in the discussion thread. The only change is that instead of logging and disconnecting in the case of invalid messages (duplicate topics or both arguments) we now return and InvalidRequest error back to the client for that topic. I would like

Re: [VOTE] KIP-4 Create Topics Schema

2016-06-19 Thread Ewen Cheslack-Postava
Don't necessarily want to add noise here, but I'm -1 based on the disconnect part. See discussion in other thread. (I'm +1 otherwise, and happy to have my vote applied assuming we clean up that one issue.) -Ewen On Thu, Jun 16, 2016 at 6:05 PM, Harsha wrote: > +1 (binding) > Thanks, > Harsha >

Re: [VOTE] KIP-4 Create Topics Schema

2016-06-16 Thread Harsha
+1 (binding) Thanks, Harsha On Thu, Jun 16, 2016, at 04:15 PM, Guozhang Wang wrote: > +1. > > On Thu, Jun 16, 2016 at 3:47 PM, Ismael Juma wrote: > > > +1 (binding) > > > > On Thu, Jun 16, 2016 at 11:50 PM, Grant Henke wrote: > > > > > I would like to initiate the voting process for the "KIP-4

Re: [VOTE] KIP-4 Create Topics Schema

2016-06-16 Thread Guozhang Wang
+1. On Thu, Jun 16, 2016 at 3:47 PM, Ismael Juma wrote: > +1 (binding) > > On Thu, Jun 16, 2016 at 11:50 PM, Grant Henke wrote: > > > I would like to initiate the voting process for the "KIP-4 Create Topics > > Schema changes". This is not a vote for all of KIP-4, but specifically > for > > the

Re: [VOTE] KIP-4 Create Topics Schema

2016-06-16 Thread Ismael Juma
+1 (binding) On Thu, Jun 16, 2016 at 11:50 PM, Grant Henke wrote: > I would like to initiate the voting process for the "KIP-4 Create Topics > Schema changes". This is not a vote for all of KIP-4, but specifically for > the create topics changes. I have included the exact changes below for > cla

[VOTE] KIP-4 Create Topics Schema

2016-06-16 Thread Grant Henke
I would like to initiate the voting process for the "KIP-4 Create Topics Schema changes". This is not a vote for all of KIP-4, but specifically for the create topics changes. I have included the exact changes below for clarity: > > Create Topics Request (KAFKA-2945 >