Re: [VOTE] KIP-272: Add API version tag to broker's RequestsPerSec metric

2018-04-02 Thread Allen Wang
Thanks everybody for voting. With 3 binding and 4 non-binding votes, I will mark the KIP as accepted. Thanks, Allen On Fri, Mar 30, 2018 at 7:11 PM, Ewen Cheslack-Postava wrote: > +1 (binding) > > The incompatibility is unfortunate, but seems unlikely to cause a problem > in practice. Let's ju

Re: [VOTE] KIP-272: Add API version tag to broker's RequestsPerSec metric

2018-03-30 Thread Ewen Cheslack-Postava
+1 (binding) The incompatibility is unfortunate, but seems unlikely to cause a problem in practice. Let's just make sure there's a note in the upgrade notes about the incompatibility when we have a PR for this. -Ewen On Fri, Mar 30, 2018 at 10:22 AM, Jun Rao wrote: > Hi, Allen, > > Thanks for

Re: [VOTE] KIP-272: Add API version tag to broker's RequestsPerSec metric

2018-03-30 Thread Jun Rao
Hi, Allen, Thanks for the explanation. That's a great point. Could you add that to the rejected section of the KIP. +1 on this KIP. Jun On Fri, Mar 30, 2018 at 10:06 AM, Allen Wang wrote: > Hi Jun, > > I think this KIP helps to gain insight into how many clients have been > upgraded *before*

Re: [VOTE] KIP-272: Add API version tag to broker's RequestsPerSec metric

2018-03-30 Thread Allen Wang
Hi Jun, I think this KIP helps to gain insight into how many clients have been upgraded *before* the we decide to upgrade the message format. In other words, users will know if they will pay down conversion cost before message format upgrade. It is about making an informed decision. To be conserva

Re: [VOTE] KIP-272: Add API version tag to broker's RequestsPerSec metric

2018-03-29 Thread Jun Rao
Hi, Allen, Thanks for the KIP. It seems the main motivation of the KIP is to estimate the ratio of the clients doing down conversion. I am wondering if we can do that by relying on the metrics we added in 1.0.0 ( https://cwiki.apache.org/confluence/display/KAFKA/KIP-188+-+Add+new+metrics+to+suppo

Re: [VOTE] KIP-272: Add API version tag to broker's RequestsPerSec metric

2018-03-29 Thread Manikumar
+1 (non-binding) On Thu, Mar 29, 2018 at 6:16 PM, Thomas Crayford wrote: > +1 (non-binding) > > On Wed, Mar 28, 2018 at 9:15 PM, Ted Yu wrote: > > > +1 > > > > On Wed, Mar 28, 2018 at 12:05 PM, Mickael Maison < > mickael.mai...@gmail.com > > > > > wrote: > > > > > +1 (non binding) > > > Thanks

Re: [VOTE] KIP-272: Add API version tag to broker's RequestsPerSec metric

2018-03-29 Thread Thomas Crayford
+1 (non-binding) On Wed, Mar 28, 2018 at 9:15 PM, Ted Yu wrote: > +1 > > On Wed, Mar 28, 2018 at 12:05 PM, Mickael Maison > > wrote: > > > +1 (non binding) > > Thanks for the KIP > > > > On Wed, Mar 28, 2018 at 6:25 PM, Gwen Shapira wrote: > > > +1 (binding) > > > > > > On Wed, Mar 28, 2018 at

Re: [VOTE] KIP-272: Add API version tag to broker's RequestsPerSec metric

2018-03-28 Thread Ted Yu
+1 On Wed, Mar 28, 2018 at 12:05 PM, Mickael Maison wrote: > +1 (non binding) > Thanks for the KIP > > On Wed, Mar 28, 2018 at 6:25 PM, Gwen Shapira wrote: > > +1 (binding) > > > > On Wed, Mar 28, 2018 at 9:55 AM, Allen Wang > wrote: > > > >> Hi All, > >> > >> I would like to start voting for

Re: [VOTE] KIP-272: Add API version tag to broker's RequestsPerSec metric

2018-03-28 Thread Mickael Maison
+1 (non binding) Thanks for the KIP On Wed, Mar 28, 2018 at 6:25 PM, Gwen Shapira wrote: > +1 (binding) > > On Wed, Mar 28, 2018 at 9:55 AM, Allen Wang wrote: > >> Hi All, >> >> I would like to start voting for KIP-272: Add API version tag to broker's >> RequestsPerSec metric. >> >> https://cwi

Re: [VOTE] KIP-272: Add API version tag to broker's RequestsPerSec metric

2018-03-28 Thread Gwen Shapira
+1 (binding) On Wed, Mar 28, 2018 at 9:55 AM, Allen Wang wrote: > Hi All, > > I would like to start voting for KIP-272: Add API version tag to broker's > RequestsPerSec metric. > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 272%3A+Add+API+version+tag+to+broker%27s+RequestsPerSec+m

[VOTE] KIP-272: Add API version tag to broker's RequestsPerSec metric

2018-03-28 Thread Allen Wang
Hi All, I would like to start voting for KIP-272: Add API version tag to broker's RequestsPerSec metric. https://cwiki.apache.org/confluence/display/KAFKA/KIP-272%3A+Add+API+version+tag+to+broker%27s+RequestsPerSec+metric Thanks, Allen