Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2018-05-09 Thread Jason Gustafson
> escribió: > > > >>>> > > > >>>>> Hi, Jorge, > > > >>>>> > > > >>>>> Thanks for the KIP. Looks good to me overall. A few comments > below. > > > >>>>> > > &

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2018-04-15 Thread Guozhang Wang
t;> Thanks for the KIP. Looks good to me overall. A few comments below. > > >>>>> > > >>>>> 1. It seems that ConsumerDescription should be MemberDescription? > > >>>>> > > >>>>> 2. Each offset can have an optional metada

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2018-02-06 Thread Jorge Esteban Quilcate Otoya
tGroupOffsetsResult, perhaps it's better to have > >>>>> KafkaFuture>, where > >>>>> OffsetAndMetadata contains an offset and a metadata of String. > >>>>> > >>>>> 3. As Jason mentioned in the discussion, it woul

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2018-02-02 Thread Matthias J. Sax
data contains an offset and a metadata of String. >>>>> >>>>> 3. As Jason mentioned in the discussion, it would be nice to extend >>> this >>>>> api to support general group management, instead of just the consumer >>>> group >>>>&g

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2018-02-01 Thread Jeff Widman
hich consists of a list of > partitions. > > > > Then, in the future, we can add other fields to Assignment. > > > > > > > > Jun > > > > > > > > > > > > On Thu, Jan 18, 2018 at 9:45 AM, Mickael Maison < > > >

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2018-01-22 Thread Jorge Esteban Quilcate Otoya
el.mai...@gmail.com> > > > wrote: > > > > > > > +1 (non binding), thanks > > > > > > > > On Thu, Jan 18, 2018 at 5:41 PM, Colin McCabe > > > wrote: > > > > > +1 (non-binding) > > > >

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2018-01-21 Thread Jun Rao
n Thu, Jan 18, 2018 at 5:41 PM, Colin McCabe > > wrote: > > > > +1 (non-binding) > > > > > > > > Colin > > > > > > > > > > > > On Thu, Jan 18, 2018, at 07:36, Ted Yu wrote: > > > >> +1 > >

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2018-01-21 Thread Jorge Esteban Quilcate Otoya
t; > Colin > > > > > > > > > On Thu, Jan 18, 2018, at 07:36, Ted Yu wrote: > > >> +1 > > >> ---- Original message ----From: Bill Bejeck < > bbej...@gmail.com> > > >> Date: 1/18/18 6:59 AM (GMT-08:00) To: dev@kafka.

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2018-01-19 Thread Jun Rao
> Colin > > > > > > On Thu, Jan 18, 2018, at 07:36, Ted Yu wrote: > >> +1 > >> Original message From: Bill Bejeck > >> Date: 1/18/18 6:59 AM (GMT-08:00) To: dev@kafka.apache.org Subject: > >> Re: [VOTE] KIP-222

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2018-01-18 Thread Mickael Maison
00) To: dev@kafka.apache.org Subject: >> Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient >> Thanks for the KIP >> >> +1 >> >> Bill >> >> On Thu, Jan 18, 2018 at 4:24 AM, Rajini Sivaram >> wrote: >> >>

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2018-01-18 Thread Colin McCabe
+1 (non-binding) Colin On Thu, Jan 18, 2018, at 07:36, Ted Yu wrote: > +1 > Original message From: Bill Bejeck > Date: 1/18/18 6:59 AM (GMT-08:00) To: dev@kafka.apache.org Subject: > Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminCl

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2018-01-18 Thread Ted Yu
+1 Original message From: Bill Bejeck Date: 1/18/18 6:59 AM (GMT-08:00) To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient Thanks for the KIP +1 Bill On Thu, Jan 18, 2018 at 4:24 AM, Rajini Sivaram wr

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2018-01-18 Thread Bill Bejeck
Thanks for the KIP +1 Bill On Thu, Jan 18, 2018 at 4:24 AM, Rajini Sivaram wrote: > +1 (binding) > > Thanks for the KIP, Jorge. > > Regards, > > Rajini > > On Wed, Jan 17, 2018 at 9:04 PM, Guozhang Wang wrote: > > > +1 (binding). Thanks Jorge. > > > > > > Guozhang > > > > On Wed, Jan 17, 2018

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2018-01-18 Thread Rajini Sivaram
+1 (binding) Thanks for the KIP, Jorge. Regards, Rajini On Wed, Jan 17, 2018 at 9:04 PM, Guozhang Wang wrote: > +1 (binding). Thanks Jorge. > > > Guozhang > > On Wed, Jan 17, 2018 at 11:29 AM, Gwen Shapira wrote: > > > Hey, since there were no additional comments in the discussion, I'd like

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2018-01-17 Thread Guozhang Wang
+1 (binding). Thanks Jorge. Guozhang On Wed, Jan 17, 2018 at 11:29 AM, Gwen Shapira wrote: > Hey, since there were no additional comments in the discussion, I'd like to > resume the voting. > > +1 (binding) > > On Fri, Nov 17, 2017 at 9:15 AM Guozhang Wang wrote: > > > Hello Jorge, > > > > I

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2018-01-17 Thread Gwen Shapira
Hey, since there were no additional comments in the discussion, I'd like to resume the voting. +1 (binding) On Fri, Nov 17, 2017 at 9:15 AM Guozhang Wang wrote: > Hello Jorge, > > I left some comments on the discuss thread. The wiki page itself looks good > overall. > > > Guozhang > > On Tue, N

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2017-11-17 Thread Guozhang Wang
Hello Jorge, I left some comments on the discuss thread. The wiki page itself looks good overall. Guozhang On Tue, Nov 14, 2017 at 10:02 AM, Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > Added. > > El mar., 14 nov. 2017 a las 19:00, Ted Yu () > escribió: > > > Please fill i

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2017-11-14 Thread Jorge Esteban Quilcate Otoya
Added. El mar., 14 nov. 2017 a las 19:00, Ted Yu () escribió: > Please fill in JIRA number in Status section. > > On Tue, Nov 14, 2017 at 9:57 AM, Jorge Esteban Quilcate Otoya < > quilcate.jo...@gmail.com> wrote: > > > JIRA issue title updated. > > > > El mar., 14 nov. 2017 a las 18:45, Ted Yu ()

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2017-11-14 Thread Ted Yu
Please fill in JIRA number in Status section. On Tue, Nov 14, 2017 at 9:57 AM, Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > JIRA issue title updated. > > El mar., 14 nov. 2017 a las 18:45, Ted Yu () > escribió: > > > Can you fill in JIRA number (KAFKA-6058 > >

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2017-11-14 Thread Jorge Esteban Quilcate Otoya
JIRA issue title updated. El mar., 14 nov. 2017 a las 18:45, Ted Yu () escribió: > Can you fill in JIRA number (KAFKA-6058 > ) ? > > If one JIRA is used for the two additions, consider updating the JIRA > title. > > On Tue, Nov 14, 2017 at 9:04 AM

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2017-11-14 Thread Ted Yu
Can you fill in JIRA number (KAFKA-6058 ) ? If one JIRA is used for the two additions, consider updating the JIRA title. On Tue, Nov 14, 2017 at 9:04 AM, Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > Hi all, > > As I didn't se

[VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2017-11-14 Thread Jorge Esteban Quilcate Otoya
Hi all, As I didn't see any further discussion around this KIP, I'd like to start voting. KIP documentation: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74686265 Cheers, Jorge.