Hello folks, I have update the KIP-222 wiki slightly upon the discussions we had during the implementations of the KIP. Please find more information on the following PRs:
https://github.com/apache/kafka/pull/4454 https://github.com/apache/kafka/pull/4856 Guozhang On Tue, Feb 6, 2018 at 2:33 PM, Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > Thanks Matthias. I have updated the version on KIP main page also. > > There are some changes that arise on the Pull Request. I will comment them > on the discussion thread. > > Cheers, > Jorge. > > El vie., 2 feb. 2018 a las 20:50, Matthias J. Sax (<matth...@confluent.io > >) > escribió: > > > Feature freeze for 1.1 passed already, thus, KIP-222 will not be part of > > 1.1 release. > > > > I updated the JIRA with target version 1.2. > > > > -Matthias > > > > On 2/1/18 3:57 PM, Jeff Widman wrote: > > > Don't forget to update the wiki page now that the vote has passed--it > > > currently says this KIP is "under discussion": > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 222+-+Add+Consumer+Group+operations+to+Admin+API > > > > > > Also, should the JIRA ticket be tagged with 1.1.0 (provided this is > > merged > > > by then)? > > > > > > On Mon, Jan 22, 2018 at 3:26 AM, Jorge Esteban Quilcate Otoya < > > > quilcate.jo...@gmail.com> wrote: > > > > > >> My bad, KIP is updated: > > >> > > >> ``` > > >> public class MemberDescription { > > >> private final String consumerId; > > >> private final String clientId; > > >> private final String host; > > >> private final MemberAssignment assignment; > > >> } > > >> public class MemberAssignment { > > >> private final List<TopicPartition> assignment; > > >> } > > >> ``` > > >> > > >> Cheers, > > >> Jorge. > > >> > > >> El lun., 22 ene. 2018 a las 6:46, Jun Rao (<j...@confluent.io>) > > escribió: > > >> > > >>> Hi, Jorge, > > >>> > > >>> For #3, I wasn't suggesting using the internal Assignment. We can > just > > >>> introduce a new public type that wraps List<TopicPartition>. We can > > call > > >> it > > >>> sth like MemberAssignment to distinguish it from the internal one. > This > > >>> makes extending the type in the future easier. > > >>> > > >>> Thanks, > > >>> > > >>> Jun > > >>> > > >>> On Sun, Jan 21, 2018 at 3:19 PM, Jorge Esteban Quilcate Otoya < > > >>> quilcate.jo...@gmail.com> wrote: > > >>> > > >>>> Hi all, > > >>>> > > >>>> Thanks all for your votes and approving this KIP :) > > >>>> > > >>>> @Jun Rao: > > >>>> > > >>>> 1. Yes, KIP is updated with MemberDescription. > > >>>> 2. Changed: > > >>>> ``` > > >>>> public class ListGroupOffsetsResult { > > >>>> final KafkaFuture<Map<TopicPartition, OffsetAndMetadata>> > future; > > >>>> ``` > > >>>> 3. Not sure about this one as Assignment type is part of > > >>>> o.a.k.clients.consumer.internals. Will we be breaking encapsulation > > >> if we > > >>>> expose it as part of AdminClient? > > >>>> Currently is defined as: > > >>>> ``` > > >>>> public class MemberDescription { > > >>>> private final String consumerId; > > >>>> private final String clientId; > > >>>> private final String host; > > >>>> private final List<TopicPartition> assignment; > > >>>> } > > >>>> ``` > > >>>> > > >>>> BTW: I've created a PR with the work in progress: > > >>>> https://github.com/apache/kafka/pull/4454 > > >>>> > > >>>> Cheers, > > >>>> Jorge. > > >>>> > > >>>> El vie., 19 ene. 2018 a las 23:52, Jun Rao (<j...@confluent.io>) > > >>> escribió: > > >>>> > > >>>>> Hi, Jorge, > > >>>>> > > >>>>> Thanks for the KIP. Looks good to me overall. A few comments below. > > >>>>> > > >>>>> 1. It seems that ConsumerDescription should be MemberDescription? > > >>>>> > > >>>>> 2. Each offset can have an optional metadata. So, in > > >>>>> ListGroupOffsetsResult, perhaps it's better to have > > >>>>> KafkaFuture<Map<TopicPartition, OffsetAndMetadata>>, where > > >>>>> OffsetAndMetadata contains an offset and a metadata of String. > > >>>>> > > >>>>> 3. As Jason mentioned in the discussion, it would be nice to extend > > >>> this > > >>>>> api to support general group management, instead of just the > consumer > > >>>> group > > >>>>> in the future. For that, it might be better for MemberDescription > to > > >>> have > > >>>>> assignment of type Assignment, which consists of a list of > > >> partitions. > > >>>>> Then, in the future, we can add other fields to Assignment. > > >>>>> > > >>>>> Jun > > >>>>> > > >>>>> > > >>>>> On Thu, Jan 18, 2018 at 9:45 AM, Mickael Maison < > > >>>> mickael.mai...@gmail.com> > > >>>>> wrote: > > >>>>> > > >>>>>> +1 (non binding), thanks > > >>>>>> > > >>>>>> On Thu, Jan 18, 2018 at 5:41 PM, Colin McCabe <cmcc...@apache.org > > > > >>>>> wrote: > > >>>>>>> +1 (non-binding) > > >>>>>>> > > >>>>>>> Colin > > >>>>>>> > > >>>>>>> > > >>>>>>> On Thu, Jan 18, 2018, at 07:36, Ted Yu wrote: > > >>>>>>>> +1 > > >>>>>>>> -------- Original message --------From: Bill Bejeck < > > >>>>> bbej...@gmail.com> > > >>>>>>>> Date: 1/18/18 6:59 AM (GMT-08:00) To: dev@kafka.apache.org > > >>>> Subject: > > >>>>>>>> Re: [VOTE] KIP-222 - Add "describe consumer group" to > > >>>> KafkaAdminClient > > >>>>>>>> Thanks for the KIP > > >>>>>>>> > > >>>>>>>> +1 > > >>>>>>>> > > >>>>>>>> Bill > > >>>>>>>> > > >>>>>>>> On Thu, Jan 18, 2018 at 4:24 AM, Rajini Sivaram < > > >>>>>> rajinisiva...@gmail.com> > > >>>>>>>> wrote: > > >>>>>>>> > > >>>>>>>>> +1 (binding) > > >>>>>>>>> > > >>>>>>>>> Thanks for the KIP, Jorge. > > >>>>>>>>> > > >>>>>>>>> Regards, > > >>>>>>>>> > > >>>>>>>>> Rajini > > >>>>>>>>> > > >>>>>>>>> On Wed, Jan 17, 2018 at 9:04 PM, Guozhang Wang < > > >>>> wangg...@gmail.com> > > >>>>>> wrote: > > >>>>>>>>> > > >>>>>>>>>> +1 (binding). Thanks Jorge. > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> Guozhang > > >>>>>>>>>> > > >>>>>>>>>> On Wed, Jan 17, 2018 at 11:29 AM, Gwen Shapira < > > >>>> g...@confluent.io > > >>>>>> > > >>>>>>>>> wrote: > > >>>>>>>>>> > > >>>>>>>>>>> Hey, since there were no additional comments in the > > >>>> discussion, > > >>>>>> I'd > > >>>>>>>>> like > > >>>>>>>>>> to > > >>>>>>>>>>> resume the voting. > > >>>>>>>>>>> > > >>>>>>>>>>> +1 (binding) > > >>>>>>>>>>> > > >>>>>>>>>>> On Fri, Nov 17, 2017 at 9:15 AM Guozhang Wang < > > >>>>> wangg...@gmail.com > > >>>>>>> > > >>>>>>>>>> wrote: > > >>>>>>>>>>> > > >>>>>>>>>>>> Hello Jorge, > > >>>>>>>>>>>> > > >>>>>>>>>>>> I left some comments on the discuss thread. The wiki > > >> page > > >>>>> itself > > >>>>>>>>> looks > > >>>>>>>>>>> good > > >>>>>>>>>>>> overall. > > >>>>>>>>>>>> > > >>>>>>>>>>>> > > >>>>>>>>>>>> Guozhang > > >>>>>>>>>>>> > > >>>>>>>>>>>> On Tue, Nov 14, 2017 at 10:02 AM, Jorge Esteban Quilcate > > >>>>> Otoya < > > >>>>>>>>>>>> quilcate.jo...@gmail.com> wrote: > > >>>>>>>>>>>> > > >>>>>>>>>>>>> Added. > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> El mar., 14 nov. 2017 a las 19:00, Ted Yu (< > > >>>>>> yuzhih...@gmail.com>) > > >>>>>>>>>>>>> escribió: > > >>>>>>>>>>>>> > > >>>>>>>>>>>>>> Please fill in JIRA number in Status section. > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> On Tue, Nov 14, 2017 at 9:57 AM, Jorge Esteban > > >>> Quilcate > > >>>>>> Otoya < > > >>>>>>>>>>>>>> quilcate.jo...@gmail.com> wrote: > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> JIRA issue title updated. > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> El mar., 14 nov. 2017 a las 18:45, Ted Yu (< > > >>>>>>>>> yuzhih...@gmail.com > > >>>>>>>>>>> ) > > >>>>>>>>>>>>>>> escribió: > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> Can you fill in JIRA number (KAFKA-6058 > > >>>>>>>>>>>>>>>> <https://issues.apache.org/ > > >> jira/browse/KAFKA-6058 > > >>>> ) > > >>>> ? > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> If one JIRA is used for the two additions, > > >>> consider > > >>>>>> updating > > >>>>>>>>>> the > > >>>>>>>>>>>> JIRA > > >>>>>>>>>>>>>>>> title. > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> On Tue, Nov 14, 2017 at 9:04 AM, Jorge Esteban > > >>>>> Quilcate > > >>>>>>>>> Otoya < > > >>>>>>>>>>>>>>>> quilcate.jo...@gmail.com> wrote: > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>> Hi all, > > >>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>> As I didn't see any further discussion around > > >>> this > > >>>>>> KIP, I'd > > >>>>>>>>>>> like > > >>>>>>>>>>>> to > > >>>>>>>>>>>>>>> start > > >>>>>>>>>>>>>>>>> voting. > > >>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>> KIP documentation: > > >>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> > > >>> https://cwiki.apache.org/confluence/pages/viewpage. > > >>>>>>>>>>>>>>> action?pageId=74686265 > > >>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>> Cheers, > > >>>>>>>>>>>>>>>>> Jorge. > > >>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>> > > >>>>>>>>>>>> > > >>>>>>>>>>>> > > >>>>>>>>>>>> > > >>>>>>>>>>>> -- > > >>>>>>>>>>>> -- Guozhang > > >>>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> -- > > >>>>>>>>>> -- Guozhang > > >>>>>>>>>> > > >>>>>>>>> > > >>>>>> > > >>>>> > > >>>> > > >>> > > >> > > > > > > > > > > > > > > -- -- Guozhang
