Re: [VOTE] KIP-208: Add SSL support to Kafka Connect REST interface

2018-01-22 Thread Jakub Scholz
Hi all, I will close the vote for this KIP. It received 4 binding +1 votes and is now approved. Thanks to everyone for voted and discussed this. The PR for this KIP is at https://github.com/apache/kafka/pull/4429 Thanks & Regards Jakub On Sat, Jan 20, 2018 at 12:07 AM, Jakub Scholz wrote: > @

Re: [VOTE] KIP-208: Add SSL support to Kafka Connect REST interface

2018-01-19 Thread Jakub Scholz
@Jason: Actually ... wouldn't it be better to name it only "rest.advertised.listener"? The "security" doesn't make much sense without the protocol. What do you think? On Fri, Jan 19, 2018 at 10:51 PM, Jakub Scholz wrote: > Hi Jason, > > Thanks for the vote. Yeah, I think that renaming it to " >

Re: [VOTE] KIP-208: Add SSL support to Kafka Connect REST interface

2018-01-19 Thread Jakub Scholz
Hi Jason, Thanks for the vote. Yeah, I think that renaming it to " rest.advertised.security.listener" is good idea. Unless someone else objects, I will update the KIP. Thanks & Regards Jakub On Fri, Jan 19, 2018 at 6:09 PM, Jason Gustafson wrote: > +1 from me. I just had one suggestion. I saw

Re: [VOTE] KIP-208: Add SSL support to Kafka Connect REST interface

2018-01-19 Thread Gwen Shapira
+1 (binding), Thank you!!! On Fri, Jan 19, 2018 at 9:09 AM Jason Gustafson wrote: > +1 from me. I just had one suggestion. I saw in the discussion thread that > you considered allowing multiple listeners for each protocol type, but > ultimately rejected it. Maybe to leave the door a little more

Re: [VOTE] KIP-208: Add SSL support to Kafka Connect REST interface

2018-01-19 Thread Jason Gustafson
+1 from me. I just had one suggestion. I saw in the discussion thread that you considered allowing multiple listeners for each protocol type, but ultimately rejected it. Maybe to leave the door a little more open in the future for this, we could rename the config "rest.advertised.security.protocol"

Re: [VOTE] KIP-208: Add SSL support to Kafka Connect REST interface

2018-01-19 Thread Damian Guy
Thanks Jakub! +1 (binding) On Thu, 18 Jan 2018 at 23:49 Jakub Scholz wrote: > Hi all, > > We still need at least 2 more binding +1s. I think that the PR ( > https://github.com/apache/kafka/pull/4429) is shaping good. If we get the > votes, we should be able to make the 1.1.0 release. > > Thanks

Re: [VOTE] KIP-208: Add SSL support to Kafka Connect REST interface

2018-01-18 Thread Jakub Scholz
Hi all, We still need at least 2 more binding +1s. I think that the PR ( https://github.com/apache/kafka/pull/4429) is shaping good. If we get the votes, we should be able to make the 1.1.0 release. Thanks & Regards Jakub On Fri, Jan 5, 2018 at 4:30 AM, Ewen Cheslack-Postava wrote: > Jakub, >

Re: [VOTE] KIP-208: Add SSL support to Kafka Connect REST interface

2018-01-04 Thread Ewen Cheslack-Postava
Jakub, I left a few comments in the discuss thread, but I'll also reply here just to bump the VOTE thread's visibility. I would like to resolve the few comments I left, but I am effectively +1 on this, the comments I left were mainly details. Committers that could help with the necessary votes wo

Re: [VOTE] KIP-208: Add SSL support to Kafka Connect REST interface

2017-11-06 Thread Jakub Scholz
Hi all, Just a reminder that htis is still up for vote. I think this is important featrue which would deserve your votes. Regards Jakub On Mon, Oct 30, 2017 at 9:24 PM, Jakub Scholz wrote: > Hi, > > It seems there are no more comments for this KIP, so I would like to start > the voting . > > F

[VOTE] KIP-208: Add SSL support to Kafka Connect REST interface

2017-10-30 Thread Jakub Scholz
Hi, It seems there are no more comments for this KIP, so I would like to start the voting . For more details about the KIP-208 go to *https://cwiki.apache.org/confluence/display/KAFKA/KIP-208%3A+Add+SSL+support+to+Kafka+Connect+REST+interface