Hi Jason, Thanks for the vote. Yeah, I think that renaming it to " rest.advertised.security.listener" is good idea. Unless someone else objects, I will update the KIP.
Thanks & Regards Jakub On Fri, Jan 19, 2018 at 6:09 PM, Jason Gustafson <ja...@confluent.io> wrote: > +1 from me. I just had one suggestion. I saw in the discussion thread that > you considered allowing multiple listeners for each protocol type, but > ultimately rejected it. Maybe to leave the door a little more open in the > future for this, we could rename the config > "rest.advertised.security.protocol" to "rest.advertised.security.listener" > so that it will still make sense if we introduce a listener labeling > approach similar to Kafka? > > Thanks, > Jason > > On Fri, Jan 19, 2018 at 8:31 AM, Damian Guy <damian....@gmail.com> wrote: > > > Thanks Jakub! > > > > +1 (binding) > > > > On Thu, 18 Jan 2018 at 23:49 Jakub Scholz <ja...@scholz.cz> wrote: > > > > > Hi all, > > > > > > We still need at least 2 more binding +1s. I think that the PR ( > > > https://github.com/apache/kafka/pull/4429) is shaping good. If we get > > the > > > votes, we should be able to make the 1.1.0 release. > > > > > > Thanks & Regards > > > Jakub > > > > > > On Fri, Jan 5, 2018 at 4:30 AM, Ewen Cheslack-Postava < > e...@confluent.io > > > > > > wrote: > > > > > > > Jakub, > > > > > > > > I left a few comments in the discuss thread, but I'll also reply here > > > just > > > > to bump the VOTE thread's visibility. I would like to resolve the few > > > > comments I left, but I am effectively +1 on this, the comments I left > > > were > > > > mainly details. > > > > > > > > Committers that could help with the necessary votes would probably be > > > Gwen > > > > and Jason (but others more than welcome to help out too :) > > > > > > > > -Ewen > > > > > > > > On Mon, Nov 6, 2017 at 1:52 AM, Jakub Scholz <ja...@scholz.cz> > wrote: > > > > > > > > > Hi all, > > > > > > > > > > Just a reminder that htis is still up for vote. I think this is > > > important > > > > > featrue which would deserve your votes. > > > > > > > > > > Regards > > > > > Jakub > > > > > > > > > > On Mon, Oct 30, 2017 at 9:24 PM, Jakub Scholz <ja...@scholz.cz> > > wrote: > > > > > > > > > > > Hi, > > > > > > > > > > > > It seems there are no more comments for this KIP, so I would like > > to > > > > > start > > > > > > the voting . > > > > > > > > > > > > For more details about the KIP-208 go to > > > > > > *https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > > > 208%3A+Add+SSL+support+to+Kafka+Connect+REST+interface > > > > > > <https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > > > 208%3A+Add+SSL+support+to+Kafka+Connect+REST+interface>* > > > > > > > > > > > > Thanks & Regards > > > > > > Jakub > > > > > > > > > > > > > > > > > > > > >
