Re: [VOTE] KIP-152 - Improve diagnostics for SASL authentication failures

2017-08-31 Thread Rajini Sivaram
This vote has passed with 5 binding (Jun, Ismael, Jason, Gwen, me) and 5 non-binding (Edo, Vahid, Manikumar, Mickael and Roger) votes. Many thanks to every one for the feedback and votes. I will update the KIP page. Regards, Rajini On Wed, Aug 30, 2017 at 1:22 PM, Gwen Shapira wrote: > Enthus

Re: [VOTE] KIP-152 - Improve diagnostics for SASL authentication failures

2017-08-30 Thread Gwen Shapira
Enthusiastic +1 from me :) It will be so helpful. On Wed, Aug 30, 2017 at 9:22 AM Roger Hoover wrote: > Great. Thank you, Rajini. > > On Wed, Aug 30, 2017 at 7:53 AM, Rajini Sivaram > wrote: > > > Hi Roger, > > > > Thank you for the suggestions. > > > > I think we should have a separate JIRA t

Re: [VOTE] KIP-152 - Improve diagnostics for SASL authentication failures

2017-08-30 Thread Roger Hoover
Great. Thank you, Rajini. On Wed, Aug 30, 2017 at 7:53 AM, Rajini Sivaram wrote: > Hi Roger, > > Thank you for the suggestions. > > I think we should have a separate JIRA to address logging improvements for > authentication. That shouldn't need a KIP. The way the code is structured > at the mom

Re: [VOTE] KIP-152 - Improve diagnostics for SASL authentication failures

2017-08-30 Thread Vahid S Hashemian
Hi Rajini, The error_message field sounds good to me too. Thanks. --Vahid From: Ismael Juma To: dev@kafka.apache.org Date: 08/30/2017 08:05 AM Subject:Re: [VOTE] KIP-152 - Improve diagnostics for SASL authentication failures Sent by:isma...@gmail.com The

Re: [VOTE] KIP-152 - Improve diagnostics for SASL authentication failures

2017-08-30 Thread Ismael Juma
The error_message field sounds good to me Rajini. I agree that we should file a separate JIRA for an authentication log. Ismael On Wed, Aug 30, 2017 at 3:53 PM, Rajini Sivaram wrote: > Hi Roger, > > Thank you for the suggestions. > > I think we should have a separate JIRA to address logging imp

Re: [VOTE] KIP-152 - Improve diagnostics for SASL authentication failures

2017-08-30 Thread Rajini Sivaram
Hi Roger, Thank you for the suggestions. I think we should have a separate JIRA to address logging improvements for authentication. That shouldn't need a KIP. The way the code is structured at the moment, SSL implementation is in the network package. And that makes it a bit messy to move authenti

Re: [VOTE] KIP-152 - Improve diagnostics for SASL authentication failures

2017-08-29 Thread Roger Hoover
Hi Rajini, One more thought. Maybe we should also add an error_message field in the response like we do with CreateTopics response so that the server can return an appropriate message that we can bubble up to the user. Examples would be "Invalid username or password", "SASL Impersonation not all

Re: [VOTE] KIP-152 - Improve diagnostics for SASL authentication failures

2017-08-29 Thread Roger Hoover
Hi Rajini, The metrics in KIP-188 will provide counts across all users but the log could potentially be used to audit individual authentication events. I think these would be useful at INFO level but if it's inconsistent with the rest of Kafka, DEBUG is ok too. The default log4j config for Kafka

Re: [VOTE] KIP-152 - Improve diagnostics for SASL authentication failures

2017-08-29 Thread Rajini Sivaram
Hi Roger, If we are changing logging level for successful SASL authentications in the broker, we should probably do the same for SSL too. Since KIP-188 proposes to add new metrics for successful and failed authentications which may be more useful for monitoring, do we really need info-level loggin

Re: [VOTE] KIP-152 - Improve diagnostics for SASL authentication failures

2017-08-29 Thread Jason Gustafson
Great improvement! +1 On Tue, Aug 29, 2017 at 10:09 AM, Roger Hoover wrote: > Just re-read the KIP and was wondering if you think INFO would be ok for > logging successful authentications? They should be relatively infrequent. > > On Tue, Aug 29, 2017 at 9:54 AM, Roger Hoover > wrote: > > > +1

Re: [VOTE] KIP-152 - Improve diagnostics for SASL authentication failures

2017-08-29 Thread Roger Hoover
Just re-read the KIP and was wondering if you think INFO would be ok for logging successful authentications? They should be relatively infrequent. On Tue, Aug 29, 2017 at 9:54 AM, Roger Hoover wrote: > +1 (non-binding). Thanks, Rajini > > On Tue, Aug 29, 2017 at 2:10 AM, Ismael Juma wrote: >

Re: [VOTE] KIP-152 - Improve diagnostics for SASL authentication failures

2017-08-29 Thread Roger Hoover
+1 (non-binding). Thanks, Rajini On Tue, Aug 29, 2017 at 2:10 AM, Ismael Juma wrote: > Thanks for the KIP, +1 (binding) from me. > > Ismael > > On Thu, Aug 24, 2017 at 6:29 PM, Rajini Sivaram > wrote: > > > Hi all, > > > > I would like to start vote on KIP-152 to improve diagnostics of > > aut

Re: [VOTE] KIP-152 - Improve diagnostics for SASL authentication failures

2017-08-29 Thread Ismael Juma
Thanks for the KIP, +1 (binding) from me. Ismael On Thu, Aug 24, 2017 at 6:29 PM, Rajini Sivaram wrote: > Hi all, > > I would like to start vote on KIP-152 to improve diagnostics of > authentication failures and to update clients to treat authentication > failures as fatal exceptions rather tha

Re: [VOTE] KIP-152 - Improve diagnostics for SASL authentication failures

2017-08-25 Thread Jun Rao
Hi, Rajini, Thanks for the KIP. +1 Jun On Thu, Aug 24, 2017 at 10:29 AM, Rajini Sivaram wrote: > Hi all, > > I would like to start vote on KIP-152 to improve diagnostics of > authentication failures and to update clients to treat authentication > failures as fatal exceptions rather than transi

Re: [VOTE] KIP-152 - Improve diagnostics for SASL authentication failures

2017-08-25 Thread Mickael Maison
om> wrote: > >> +1 >> >> Thanks Rajini. >> >> --Vahid >> >> >> >> From: Edoardo Comar >> To: dev@kafka.apache.org >> Date: 08/24/2017 10:55 AM >> Subject:Re: [VOTE] KIP-152 - Improve

Re: [VOTE] KIP-152 - Improve diagnostics for SASL authentication failures

2017-08-25 Thread Manikumar
> > > > From: Rajini Sivaram > To: dev > Date: 24/08/2017 18:30 > Subject:[VOTE] KIP-152 - Improve diagnostics for SASL > authentication failures > > > > Hi all, > > I would like to start vote on KIP-152 to improve diagnostics of > authentic

Re: [VOTE] KIP-152 - Improve diagnostics for SASL authentication failures

2017-08-24 Thread Vahid S Hashemian
+1 Thanks Rajini. --Vahid From: Edoardo Comar To: dev@kafka.apache.org Date: 08/24/2017 10:55 AM Subject:Re: [VOTE] KIP-152 - Improve diagnostics for SASL authentication failures Thanks Rajini! +1 (non-binding) -- Edoardo

Re: [VOTE] KIP-152 - Improve diagnostics for SASL authentication failures

2017-08-24 Thread Edoardo Comar
Thanks Rajini! +1 (non-binding) -- Edoardo Comar IBM Message Hub IBM UK Ltd, Hursley Park, SO21 2JN From: Rajini Sivaram To: dev Date: 24/08/2017 18:30 Subject:[VOTE] KIP-152 - Improve diagnostics for SASL authentication

[VOTE] KIP-152 - Improve diagnostics for SASL authentication failures

2017-08-24 Thread Rajini Sivaram
Hi all, I would like to start vote on KIP-152 to improve diagnostics of authentication failures and to update clients to treat authentication failures as fatal exceptions rather than transient errors: https://cwiki.apache.org/confluence/display/KAFKA/KIP-152+-+Improve+diagnostics+for+SASL+authenti