This vote has passed with 5 binding (Jun, Ismael, Jason, Gwen, me) and 5
non-binding (Edo, Vahid, Manikumar, Mickael and Roger) votes.
Many thanks to every one for the feedback and votes. I will update the KIP
page.
Regards,
Rajini
On Wed, Aug 30, 2017 at 1:22 PM, Gwen Shapira wrote:
> Enthus
Enthusiastic +1 from me :)
It will be so helpful.
On Wed, Aug 30, 2017 at 9:22 AM Roger Hoover wrote:
> Great. Thank you, Rajini.
>
> On Wed, Aug 30, 2017 at 7:53 AM, Rajini Sivaram
> wrote:
>
> > Hi Roger,
> >
> > Thank you for the suggestions.
> >
> > I think we should have a separate JIRA t
Great. Thank you, Rajini.
On Wed, Aug 30, 2017 at 7:53 AM, Rajini Sivaram
wrote:
> Hi Roger,
>
> Thank you for the suggestions.
>
> I think we should have a separate JIRA to address logging improvements for
> authentication. That shouldn't need a KIP. The way the code is structured
> at the mom
Hi Rajini,
The error_message field sounds good to me too.
Thanks.
--Vahid
From: Ismael Juma
To: dev@kafka.apache.org
Date: 08/30/2017 08:05 AM
Subject:Re: [VOTE] KIP-152 - Improve diagnostics for SASL
authentication failures
Sent by:isma...@gmail.com
The
The error_message field sounds good to me Rajini. I agree that we should
file a separate JIRA for an authentication log.
Ismael
On Wed, Aug 30, 2017 at 3:53 PM, Rajini Sivaram
wrote:
> Hi Roger,
>
> Thank you for the suggestions.
>
> I think we should have a separate JIRA to address logging imp
Hi Roger,
Thank you for the suggestions.
I think we should have a separate JIRA to address logging improvements for
authentication. That shouldn't need a KIP. The way the code is structured
at the moment, SSL implementation is in the network package. And that makes
it a bit messy to move authenti
Hi Rajini,
One more thought. Maybe we should also add an error_message field in the
response like we do with CreateTopics response so that the server can
return an appropriate message that we can bubble up to the user. Examples
would be "Invalid username or password", "SASL Impersonation not all
Hi Rajini,
The metrics in KIP-188 will provide counts across all users but the log
could potentially be used to audit individual authentication events. I
think these would be useful at INFO level but if it's inconsistent with the
rest of Kafka, DEBUG is ok too. The default log4j config for Kafka
Hi Roger,
If we are changing logging level for successful SASL authentications in the
broker, we should probably do the same for SSL too. Since KIP-188 proposes
to add new metrics for successful and failed authentications which may be
more useful for monitoring, do we really need info-level loggin
Great improvement! +1
On Tue, Aug 29, 2017 at 10:09 AM, Roger Hoover
wrote:
> Just re-read the KIP and was wondering if you think INFO would be ok for
> logging successful authentications? They should be relatively infrequent.
>
> On Tue, Aug 29, 2017 at 9:54 AM, Roger Hoover
> wrote:
>
> > +1
Just re-read the KIP and was wondering if you think INFO would be ok for
logging successful authentications? They should be relatively infrequent.
On Tue, Aug 29, 2017 at 9:54 AM, Roger Hoover
wrote:
> +1 (non-binding). Thanks, Rajini
>
> On Tue, Aug 29, 2017 at 2:10 AM, Ismael Juma wrote:
>
+1 (non-binding). Thanks, Rajini
On Tue, Aug 29, 2017 at 2:10 AM, Ismael Juma wrote:
> Thanks for the KIP, +1 (binding) from me.
>
> Ismael
>
> On Thu, Aug 24, 2017 at 6:29 PM, Rajini Sivaram
> wrote:
>
> > Hi all,
> >
> > I would like to start vote on KIP-152 to improve diagnostics of
> > aut
Thanks for the KIP, +1 (binding) from me.
Ismael
On Thu, Aug 24, 2017 at 6:29 PM, Rajini Sivaram
wrote:
> Hi all,
>
> I would like to start vote on KIP-152 to improve diagnostics of
> authentication failures and to update clients to treat authentication
> failures as fatal exceptions rather tha
Hi, Rajini,
Thanks for the KIP. +1
Jun
On Thu, Aug 24, 2017 at 10:29 AM, Rajini Sivaram
wrote:
> Hi all,
>
> I would like to start vote on KIP-152 to improve diagnostics of
> authentication failures and to update clients to treat authentication
> failures as fatal exceptions rather than transi
om> wrote:
>
>> +1
>>
>> Thanks Rajini.
>>
>> --Vahid
>>
>>
>>
>> From: Edoardo Comar
>> To: dev@kafka.apache.org
>> Date: 08/24/2017 10:55 AM
>> Subject:Re: [VOTE] KIP-152 - Improve
>
>
>
> From: Rajini Sivaram
> To: dev
> Date: 24/08/2017 18:30
> Subject:[VOTE] KIP-152 - Improve diagnostics for SASL
> authentication failures
>
>
>
> Hi all,
>
> I would like to start vote on KIP-152 to improve diagnostics of
> authentic
+1
Thanks Rajini.
--Vahid
From: Edoardo Comar
To: dev@kafka.apache.org
Date: 08/24/2017 10:55 AM
Subject:Re: [VOTE] KIP-152 - Improve diagnostics for SASL
authentication failures
Thanks Rajini!
+1 (non-binding)
--
Edoardo
Thanks Rajini!
+1 (non-binding)
--
Edoardo Comar
IBM Message Hub
IBM UK Ltd, Hursley Park, SO21 2JN
From: Rajini Sivaram
To: dev
Date: 24/08/2017 18:30
Subject:[VOTE] KIP-152 - Improve diagnostics for SASL
authentication
Hi all,
I would like to start vote on KIP-152 to improve diagnostics of
authentication failures and to update clients to treat authentication
failures as fatal exceptions rather than transient errors:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-152+-+Improve+diagnostics+for+SASL+authenti
19 matches
Mail list logo