Re: [VOTE] KIP-1091: Improved Kafka Streams operator metrics

2025-01-17 Thread Matthias J. Sax
We made a small last minute change to the KIP, adding `processId` tag to the newly added `thread-state` metric. Cf https://github.com/apache/kafka/pull/18581 W/o this tag, it's not possible to map threads to KS clients, as we use AdminClient to collect KS client metrics, but the KafkaConsumer

Re: [VOTE] KIP-1091: Improved Kafka Streams operator metrics

2024-11-12 Thread Bill Bejeck
All, Quick update on KIP-1091. In an offline discussion, it was brought up that the existing JMX metric for the client state is named "state", so we'll update the name for the JMX thread state metric to "state" as well. Thanks, Bill On Mon, Nov 11, 2024 at 12:59 PM Bill Bejeck wrote: > Hi All

Re: [VOTE] KIP-1091: Improved Kafka Streams operator metrics

2024-11-11 Thread Bill Bejeck
Hi All, The vote is now closed. KIP-1091 has been accepted with 3 binding votes (Lucas, Matthias, and Sophie) and 1 non-binding vote (Apoorv). Thanks to everyone for participating. -Bill On Wed, Nov 6, 2024 at 11:40 PM Sophie Blee-Goldman wrote: > +1 (binding) > > thanks Bill > > On Wed, Nov

Re: [VOTE] KIP-1091: Improved Kafka Streams operator metrics

2024-11-06 Thread Sophie Blee-Goldman
+1 (binding) thanks Bill On Wed, Nov 6, 2024 at 4:44 PM Matthias J. Sax wrote: > +1 (binding) > > On 11/6/24 3:39 AM, Apoorv Mittal wrote: > > Hi Bill, > > Thanks for the KIP. > > > > +1 (non-binding) > > > > Regards, > > Apoorv Mittal > > > > > > On Wed, Nov 6, 2024 at 10:55 AM Lucas Brutschy

Re: [VOTE] KIP-1091: Improved Kafka Streams operator metrics

2024-11-06 Thread Matthias J. Sax
+1 (binding) On 11/6/24 3:39 AM, Apoorv Mittal wrote: Hi Bill, Thanks for the KIP. +1 (non-binding) Regards, Apoorv Mittal On Wed, Nov 6, 2024 at 10:55 AM Lucas Brutschy wrote: Hey Bill, thanks for the KIP! +1 (binding) Cheers, Lucas On Wed, Nov 6, 2024 at 2:00 AM Bill Bejeck wrote:

Re: [VOTE] KIP-1091: Improved Kafka Streams operator metrics

2024-11-06 Thread Lucas Brutschy
Hey Bill, thanks for the KIP! +1 (binding) Cheers, Lucas On Wed, Nov 6, 2024 at 2:00 AM Bill Bejeck wrote: > > Hi All, > > I'd like to call for a vote on KIP-1091 > > (discussion thread > <

Re: [VOTE] KIP-1091: Improved Kafka Streams operator metrics

2024-11-06 Thread Apoorv Mittal
Hi Bill, Thanks for the KIP. +1 (non-binding) Regards, Apoorv Mittal On Wed, Nov 6, 2024 at 10:55 AM Lucas Brutschy wrote: > Hey Bill, > > thanks for the KIP! > > +1 (binding) > > Cheers, > Lucas > > On Wed, Nov 6, 2024 at 2:00 AM Bill Bejeck wrote: > > > > Hi All, > > > > I'd like to call f

[VOTE] KIP-1091: Improved Kafka Streams operator metrics

2024-11-05 Thread Bill Bejeck
Hi All, I'd like to call for a vote on KIP-1091 (discussion thread ) Thanks, Bill