We made a small last minute change to the KIP, adding `processId` tag to
the newly added `thread-state` metric.
Cf https://github.com/apache/kafka/pull/18581
W/o this tag, it's not possible to map threads to KS clients, as we use
AdminClient to collect KS client metrics, but the KafkaConsumer to
collect thread metrics.
If a broker plugin cannot map the metrics to each others it would be
somewhat problematic...
For all other metrics, adding `processId` is not necessary, as they are
sent via the same consumer and share the same `client.instance.id`.
-Matthias
On 11/12/24 10:35 AM, Bill Bejeck wrote:
All,
Quick update on KIP-1091. In an offline discussion, it was brought up that
the existing JMX metric for the client state is named "state", so we'll
update the name for the JMX thread state metric to "state" as well.
Thanks,
Bill
On Mon, Nov 11, 2024 at 12:59 PM Bill Bejeck <bbej...@gmail.com> wrote:
Hi All,
The vote is now closed.
KIP-1091 has been accepted with 3 binding votes (Lucas, Matthias, and
Sophie) and 1 non-binding vote (Apoorv).
Thanks to everyone for participating.
-Bill
On Wed, Nov 6, 2024 at 11:40 PM Sophie Blee-Goldman <sop...@responsive.dev>
wrote:
+1 (binding)
thanks Bill
On Wed, Nov 6, 2024 at 4:44 PM Matthias J. Sax <mj...@apache.org> wrote:
+1 (binding)
On 11/6/24 3:39 AM, Apoorv Mittal wrote:
Hi Bill,
Thanks for the KIP.
+1 (non-binding)
Regards,
Apoorv Mittal
On Wed, Nov 6, 2024 at 10:55 AM Lucas Brutschy
<lbruts...@confluent.io.invalid> wrote:
Hey Bill,
thanks for the KIP!
+1 (binding)
Cheers,
Lucas
On Wed, Nov 6, 2024 at 2:00 AM Bill Bejeck <bbej...@apache.org>
wrote:
Hi All,
I'd like to call for a vote on KIP-1091
<
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1091%3A+Improved+Kafka+Streams+operator+metrics
(discussion thread
<https://lists.apache.org/thread/gl745vzfb8cfk3zrd8hykzwnqolnqncn>)
Thanks,
Bill
