Re: [VOTE] 3.9.0 RC5

2024-11-08 Thread Chia-Ping Tsai
hi Kamal Nice find. I checked those tests, and they are unrelated to production code—they're just something we missed during the backport. I've filed KAFKA-17969 to fix it. Thanks, Chia-Ping On 2024/11/08 10:40:07 Kamal Chandraprakash wrote: > Hi all, > > I took the 3.9 branch

Re: [VOTE] 3.9.0 RC5

2024-11-08 Thread Kamal Chandraprakash
Hi all, I took the 3.9 branch from upstream and ran all the unit tests. The StorageToolTest unit test is failing consistently: % ./gradlew core:test --tests StorageToolTest Gradle Test Run :core:test > Gradle Test Executor 20 > StorageToolTest > testFo

Re: [VOTE] 3.9.0 RC5

2024-11-07 Thread Colin McCabe
Thanks, Josep. best, Colin On Wed, Nov 6, 2024, at 23:58, Josep Prat wrote: > Hi Colin, > I see that you made 3.9 the default docs version in Kafka-Site. However, as > your doc changes were pushed before the 3.8.1 release, now the upgrade.html > page doesn't mention 3.8.1 at all. I'll update the

Re: [VOTE] 3.9.0 RC5

2024-11-06 Thread Josep Prat
Hi Colin, I see that you made 3.9 the default docs version in Kafka-Site. However, as your doc changes were pushed before the 3.8.1 release, now the upgrade.html page doesn't mention 3.8.1 at all. I'll update the site. On Wed, Nov 6, 2024 at 4:48 PM Viktor Somogyi-Vass wrote: > Ok, sorry for the

Re: [VOTE] 3.9.0 RC5

2024-11-06 Thread Viktor Somogyi-Vass
Ok, sorry for the noise. It seems like my setup was incorrectly configured, one controller had an incorrect voters config and that caused the issue. Retested it and it works now. But given this, I might as well just give a +1. :) On Wed, Nov 6, 2024 at 2:53 PM Viktor Somogyi-Vass < viktor.somo...@

Re: [VOTE] 3.9.0 RC5

2024-11-06 Thread Viktor Somogyi-Vass
Hey All, It seems like I ran into an issue. While trying to do the migration (3.9 ZK -> 3.9 KRaft), at the very last step the whole cluster (except the controller I just restarted) fails with a fatal error where a controller (I think) requests a truncation that is below the HWM. I tried to capture

Re: [VOTE] 3.9.0 RC5

2024-11-01 Thread Colin McCabe
Argh. That should read "5 +1 votes". :) Thanks, everyone. Colin On Fri, Nov 1, 2024, at 14:58, Colin McCabe wrote: > Hi all, > > This vote passes with 7 +1 votes (3 bindings) and no 0 or -1 votes. > > +1 votes > PMC Members: > * Justine Olshan > * Bill Bejeck > * David Arthur > * Luke Chen > > C

Re: [VOTE] 3.9.0 RC5

2024-11-01 Thread Colin McCabe
Hi all, This vote passes with 7 +1 votes (3 bindings) and no 0 or -1 votes. +1 votes PMC Members: * Justine Olshan * Bill Bejeck * David Arthur * Luke Chen Community: * Federico Valeri 0 votes * No votes -1 votes * No votes Vote thread: https://lists.apache.org/thread/og8l24z8oj87x0zsoqddfxo5

Re: [VOTE] 3.9.0 RC5

2024-10-31 Thread Luke Chen
Hi Colin, Thanks for the update. I've ran a sanity check as Mickael suggested for the maven artifacts with the one in https://dist.apache.org/repos/dist/dev/kafka/3.9.0-rc5/. I used jarcomp to verify: 1. kafka_2.13-3.9.0.jar 2. kafka-clien

Re: [VOTE] 3.9.0 RC5

2024-10-31 Thread Colin McCabe
Hi David, Thanks for checking. I took a look and yes, I did forget to upload the Scala 2.12 artifacts previously. The script runs gradlewAll, but when I was trying to do the steps manually, I missed that and just ran gradlew, which only did Scala 2.13. This should be fixed now! The scala 2.12

Re: [VOTE] 3.9.0 RC5

2024-10-31 Thread Mickael Maison
Hi, Can we add sanity checks to ensure all artifacts are present when running the release? Also should we use a different folder for each RC? This would eliminate the risk of artifacts from previous RCs hiding an issue. Luke spotted the old artifacts this time but this could have been missed. Tha

Re: [VOTE] 3.9.0 RC5

2024-10-31 Thread David Arthur
Assuming the Maven artifacts are not an issue, I'll go ahead and give my vote. For validation, I downloaded the Scala 2.13 binaries and manually ran through a ZK to KRaft migration. +1 binding -David On Thu, Oct 31, 2024 at 11:35 AM Bill Bejeck wrote: > Hi Colin, > > Thanks for the new RC. >

Re: [VOTE] 3.9.0 RC5

2024-10-31 Thread Bill Bejeck
Hi Colin, Thanks for the new RC. - I checked the signatures and checksums - Built from source - Ran though the quickstart - Spot checked the docs +1(binding) from me modulo the previous issues pointed out. Thanks, Bill On Wed, Oct 30, 2024 at 2:02 PM David Arthur wrote: > Should

Re: [VOTE] 3.9.0 RC5

2024-10-30 Thread Colin McCabe
Thanks for checking, Luke. I did actually visit https://repository.apache.org/#stagingRepositories and hit close on the artifacts as the release.py script says to do. I don't know why they ended up not showing up. Today I dropped all the maven artifacts for previous 3.9 RCs, switched to java 8

Re: [VOTE] 3.9.0 RC5

2024-10-30 Thread David Arthur
Should there be Scala 2.12 artifacts in the Maven staging? I see these for 2.13: * https://repository.apache.org/content/groups/staging/org/apache/kafka/kafka_2.13/3.9.0/ * https://repository.apache.org/content/groups/staging/org/apache/kafka/kafka-streams-scala_2.13/3.9.0/ but I don't see 2.12 f

Re: [VOTE] 3.9.0 RC5

2024-10-30 Thread Federico Valeri
Hi, I did the following tests: - Built from source - Ran all unit and integration tests - Spot checked the documentation - Tried Maven dependencies - Tested KIP-853, KIP-950, KIP-956 and KIP-1057 I also noticed that Maven artifacts were not updated. +1 (non binding) Thanks Fede On Wed, Oct 30,

Re: [VOTE] 3.9.0 RC5

2024-10-30 Thread Luke Chen
Hi Justine, > As a side note, I was looking into how to configure kip-853 and it took me a moment to find the instructions in the documentation, I wonder if it could be included in the notable changes section of the upgrade notes. Not a blocker as I believe we can still update documentation. Good

Re: [VOTE] 3.9.0 RC5

2024-10-29 Thread Luke Chen
Hi Colin, I was trying to test the RC, but I found the artifacts in Maven artifacts to be voted upon are not up-to-date. Not only the "Last Modified" time in the 3.9.0 artifacts are on Oct. 10, but also the source code in the artifacts didn't include the latest commits in RC5 here

Re: [VOTE] 3.9.0 RC5

2024-10-29 Thread Justine Olshan
Hey Colin, Thanks for the new RC. I've tested the --feature functionality that was missing before. Seems to be working as expected now. As a side note, I was looking into how to configure kip-853 and it took me a moment to find the instructions in the documentation, I wonder if it could be include

Re: [VOTE] 3.9.0 RC5

2024-10-29 Thread Colin McCabe
Thanks, Anton. And thanks Chia-Ping Tsai for taking a look at how we can improve the docs here... best, Colin On Tue, Oct 29, 2024, at 02:39, Anton Agestam wrote: > Hi Chia-Ping, > > Thanks for pointing those two fields out. I retract my -1. > > Cheers, > Anton > > Den sön 27 okt. 2024 kl 17:40

Re: [VOTE] 3.9.0 RC5

2024-10-29 Thread Anton Agestam
Hi Chia-Ping, Thanks for pointing those two fields out. I retract my -1. Cheers, Anton Den sön 27 okt. 2024 kl 17:40 skrev Chia-Ping Tsai : > hi Anton > > Thanks for sharing your insights on Kafka serialization—it’s really cool > and interesting to me. Additionally, you inspired me to file a JI

Re: [VOTE] 3.9.0 RC5

2024-10-27 Thread Chia-Ping Tsai
hi Anton Thanks for sharing your insights on Kafka serialization—it’s really cool and interesting to me. Additionally, you inspired me to file a JIRA issue (KAFKA-17882) to improve the documentation. The most important aspect of Kafka is compatibility, and the undocumented behavior has been in

Re: [VOTE] 3.9.0 RC5

2024-10-27 Thread Anton Agestam
-1, refer to comments on the RC 2 thread. Den sön 27 okt. 2024 kl 02:51 skrev Colin McCabe : > This is the RC5 candidate for the release of Apache Kafka 3.9.0. > > - This is a major release, the final one in the 3.x line. (There may of > course be other minor releases in this line, such as 3.9.1.

[VOTE] 3.9.0 RC5

2024-10-26 Thread Colin McCabe
This is the RC5 candidate for the release of Apache Kafka 3.9.0. - This is a major release, the final one in the 3.x line. (There may of course be other minor releases in this line, such as 3.9.1.) - Tiered storage will be considered production-ready in this release. - This will be the final majo