Re: [DISCUSS] Notify SourceTask of ACK'd offsets, metadata

2019-10-01 Thread Ryanne Dolan
Huh. Not sure how that happened. Will update the KIP, thanks. On Tue, Oct 1, 2019 at 9:12 AM Randall Hauch wrote: > There seems to be two discussion threads for this KIP, and I replied to the > other thread that includes the KIP number. Shall I repeat it here? > > Also, the link to the discussi

Re: [DISCUSS] Notify SourceTask of ACK'd offsets, metadata

2019-10-01 Thread Randall Hauch
There seems to be two discussion threads for this KIP, and I replied to the other thread that includes the KIP number. Shall I repeat it here? Also, the link to the discussion thread on https://cwiki.apache.org/confluence/display/KAFKA/KIP-416%3A+Notify+SourceTask+of+ACK%27d+offsets%2C+metadata sh

Re: [DISCUSS] Notify SourceTask of ACK'd offsets, metadata

2019-01-30 Thread Ryanne Dolan
I've updated the KIP and PR to overload commitRecord instead of adding a new method. Here's the PR: https://github.com/apache/kafka/pull/6171 Ryanne On Mon, Jan 21, 2019 at 6:29 PM Ryanne Dolan wrote: > Andrew Schofield suggested we overload the commitRecord method instead of > adding a new on

Re: [DISCUSS] Notify SourceTask of ACK'd offsets, metadata

2019-01-21 Thread Ryanne Dolan
Andrew Schofield suggested we overload the commitRecord method instead of adding a new one. Thoughts? Ryanne On Thu, Jan 17, 2019, 5:34 PM Ryanne Dolan I had to change the KIP number (concurrency is hard!) so the link is now: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-416%3A+Not

Re: [DISCUSS] Notify SourceTask of ACK'd offsets, metadata

2019-01-17 Thread Ryanne Dolan
I had to change the KIP number (concurrency is hard!) so the link is now: https://cwiki.apache.org/confluence/display/KAFKA/KIP-416%3A+Notify+SourceTask+of+ACK%27d+offsets%2C+metadata Ryanne On Fri, Jan 11, 2019 at 2:43 PM Ryanne Dolan wrote: > Hey y'all, > > Please review the following small

[DISCUSS] Notify SourceTask of ACK'd offsets, metadata

2019-01-11 Thread Ryanne Dolan
Hey y'all, Please review the following small KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-414%3A+Notify+SourceTask+of+ACK%27d+offsets%2C+metadata Thanks! Ryanne