I've updated the KIP and PR to overload commitRecord instead of adding a new method. Here's the PR:
https://github.com/apache/kafka/pull/6171 Ryanne On Mon, Jan 21, 2019 at 6:29 PM Ryanne Dolan <ryannedo...@gmail.com> wrote: > Andrew Schofield suggested we overload the commitRecord method instead of > adding a new one. Thoughts? > > Ryanne > > On Thu, Jan 17, 2019, 5:34 PM Ryanne Dolan <ryannedo...@gmail.com wrote: > >> I had to change the KIP number (concurrency is hard!) so the link is now: >> >> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-416%3A+Notify+SourceTask+of+ACK%27d+offsets%2C+metadata >> >> Ryanne >> >> On Fri, Jan 11, 2019 at 2:43 PM Ryanne Dolan <ryannedo...@gmail.com> >> wrote: >> >>> Hey y'all, >>> >>> Please review the following small KIP: >>> >>> >>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-414%3A+Notify+SourceTask+of+ACK%27d+offsets%2C+metadata >>> >>> Thanks! >>> Ryanne >>> >>
