Hi Tom,
Thanks for your review.
My original intent was to use the naming available in TimeUnit doc :
https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/TimeUnit.html
This led me to follow their logic : "toMicros", "toNanos", etc.
By looking around the kafka code to see if there was so
Hi Julien,
Thanks! A couple of other points sprang to mind:
1. seconds is a unit, but millis etc are really just prefixes. I can
imagine what my old physics teacher would have to say about mixing these
concepts :-). I would have preferred to use the abbreviations s, ms, µs and
ns (ms in particula
Hi Tom and thanks for your review,
I agree and I have renamed the field name to unix.precision.
I've replaced all references to the word "epoch" which I mistakenly used to
describe measurements throughout the KIP.
I have also modified the KIP name as well.
Before : Add support for unix epoch preci
Hi Julien,
I wonder if the name epoch.precision is a little confusing. An epoch is a
point in time chosen as a origin for a particular calendar system. As such
it doesn't have a precision. It's only measurements from this point in time
which have a precision. In the unix case, precisions of second
Hi Mickael,
Thank you very much for your feedback and direction.
I have added the documentation to the "Public Interfaces" chapter
(formatted in a table as I've seen in other KIPs) and I'll put this
KIP to a vote next week as per your suggestion.
Regards,
Julien
Le mer. 12 janv. 2022 à 18:19,
Hi Julien,
Thanks for the KIP. I looks like a useful improvement to the
TimestampConverter SMT.
I'd suggest adding the documentation for the new setting to the KIP.
I've had to go check your PR to fully understand how you want to use
it, both for input and output.
Apart from that, if you don't ge
Hi everyone,
Bumping this KIP discussion.
It's a small change, entirely backward compatible and I'd love your
feedback on it.
Thanks,
Julien
Le jeu. 9 déc. 2021 à 21:56, Julien Chanaud a écrit :
>
> Hi everyone,
>
> I would like to start a discussion for KIP-808
> https://cwiki.apache.org/confl
Hi everyone,
I would like to start a discussion for KIP-808
https://cwiki.apache.org/confluence/display/KAFKA/KIP-808%3A+Add+support+for+unix+epoch+precision+in+TimestampConverter+SMT
This seems like a simple change but I suspect there are several things to
consider, most notably regarding the ja